Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#18347 - Element 'css', attribute 'as': The attribute 'as' is not allowed. (CSS preloading) #20495

Conversation

vasilii-b
Copy link

@vasilii-b vasilii-b commented Jan 23, 2019

Description (*)

Added as attribute to linkType in lib/internal/Magento/Framework/View/Layout/etc/head.xsd with 3 possible options: style, script and font. Why only these 3 ? Because in my opinion only those should be added to the head (and would be needed by developers).

Related links:

Fixed Issues (if relevant)

  1. Element 'css', attribute 'as': The attribute 'as' is not allowed. (CSS preloading) #18347: Element 'css', attribute 'as': The attribute 'as' is not allowed. (CSS preloading)

Manual testing scenarios (*)

Described in the Issue's description.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

…not allowed. (CSS preloading)

- Added as attribute to linkType with 3 possible options: style, script and font
@magento-engcom-team
Copy link
Contributor

Hi @vasilii-b. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added Component: Framework/View Release Line: 2.3 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Jan 23, 2019
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Jan 23, 2019
@okorshenko okorshenko removed this from the Release: 2.3.1 milestone Jan 28, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-3932 has been created to process this Pull Request

@ghost
Copy link

ghost commented Feb 15, 2019

Hi @vasilii-b, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants