Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

13982 customer login block sets the title for the page when rendered #20583

Merged
merged 2 commits into from
Feb 25, 2019
Merged

13982 customer login block sets the title for the page when rendered #20583

merged 2 commits into from
Feb 25, 2019

Conversation

lisovyievhenii
Copy link
Contributor

Description

The main Customer Login Block, Magento\Customer\Block\Form\Loginsets up the page title.
If you use this block on any page, it rewrites the page title to "Customer Login".

Fixed Issues

  1. Customer Login Block sets the title for the page when rendered #13982: Customer Login Block sets the title for the page when rendered

Manual testing scenarios

  1. Go to Magento login page. The title of the page should be equal to "Customer Login"
  2. Insert Magento/Customer/Block/Login Block into any page
  3. The title of that page not be overridden by string "Customer Login"

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@lisovyievhenii
magento#13982: Customer Login Block sets the title for the page when …
122e5c2 
…rendered. Move setPageTitle from Block to layout configs
@magento-engcom-team
Copy link
Contributor

Hi @lisovyievhenii. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added Area: Frontend Component: Customer Release Line: 2.3 Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner labels Jan 24, 2019
@robbie-thompson
Copy link

robbie-thompson commented Jan 24, 2019 •
edited
Loading

This won't work for the <head> title, which the original PHP function is for

@vpodorozh
Copy link
Contributor

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @vpodorozh. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @vpodorozh, here is your new Magento instance.
Admin access: https://pr-20583.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@lisovyievhenii
Copy link
Contributor Author

lisovyievhenii commented Jan 25, 2019 •
edited
Loading

@robbie-thompson , you're right. I moved it into <head><title> in the layout xml file.
It is translatable, title is shown both in the <head> and on page.
Done in the same way as on "Forgot password" page

@robbie-thompson
Copy link

@lisovyievhenii Awesome, I've ran into this issue and similar ones before (it's the same for Register, Book, History, etc). Great to see it being fixed!

@novikor novikor requested review from swnsma and novikor January 26, 2019 13:57
@VladimirZaets VladimirZaets self-assigned this Jan 29, 2019
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-4047 has been created to process this Pull Request

@swnsma swnsma removed their request for review January 30, 2019 12:36
@sivaschenko sivaschenko changed the base branch from 2.3-develop to 2.2-develop February 23, 2019 12:04
@sivaschenko sivaschenko changed the base branch from 2.2-develop to 2.3-develop February 23, 2019 12:04
@magento-engcom-team magento-engcom-team mentioned this pull request Feb 25, 2019
Closed
@magento-engcom-team magento-engcom-team merged commit 93f1caa into magento:2.3-develop Feb 25, 2019
@ghost
Copy link

ghost commented Feb 25, 2019

Hi @lisovyievhenii, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Feb 25, 2019
@sivaschenko
ENGCOM-4047: 13982 customer login block sets the title for the page w…
a27b32e 
…hen rendered #20583
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.2 milestone Feb 25, 2019
@amol2jcommerce amol2jcommerce mentioned this pull request Feb 25, 2019
Merged
4 tasks
@mfickers mfickers mentioned this pull request Feb 28, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VladimirZaets VladimirZaets VladimirZaets approved these changes

@novikor novikor novikor approved these changes

Assignees

@VladimirZaets VladimirZaets

Labels
Area: Frontend Award: bug fix Component: Customer Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.2
Development

Successfully merging this pull request may close these issues.
6 participants
@lisovyievhenii @magento-engcom-team @robbie-thompson @vpodorozh @VladimirZaets @novikor