-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Direct STDERR output when listing crontab to /dev/null #20951
Direct STDERR output when listing crontab to /dev/null #20951
Conversation
When installing crontab on systems using fcron the output from STDERR is captured and inserted into the updated crontab. An example from a fresh install follows. While fcron does not outright complain about this when saving the file, it is messy and quite avoidable. 2019-02-03 13:18:18 INFO listing magento's fcrontab #~ MAGENTO START 7cd0a74c421051ec6cce8936eb9edd02 * * * * * /usr/lib64/php7.2/bin/php /var/www/magento/bin/magento cron:run 2>&1 | grep -v "Ran jobs by schedule" >> /var/www/magento/var/log/magento.cron.log * * * * * /usr/lib64/php7.2/bin/php /var/www/magento/update/cron.php >> /var/www/magento/var/log/update.cron.log * * * * * /usr/lib64/php7.2/bin/php /var/www/magento/bin/magento setup:cron:run >> /var/www/magento/var/log/setup.cron.log #~ MAGENTO END 7cd0a74c421051ec6cce8936eb9edd02
Hi @danielatdattrixdotcom. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
@magento-engcom-team give me test instance |
Hi @danielatdattrixdotcom. Thank you for your request. I'm working on Magento instance for you |
Hi @danielatdattrixdotcom, here is your new Magento instance. |
Hi @ihor-sviziev, thank you for the review. |
@danielatdattrixdotcom thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository. |
Fix unit test failures
Hi @ihor-sviziev, thank you for the review. |
I was not able to reproduce the issue. STDERR content generated during crontab command execution is not added to the crontab content. However, I think this pull request should be merged in order to ensure STDERR is not included in the crontab content on specific environments. |
Hi @danielatdattrixdotcom, thank you for your contribution! |
Description (*)
When installing crontab on systems using fcron the output from STDERR is captured and inserted into the updated crontab. An example from a fresh install follows. While fcron does not outright complain about this when saving the file, it is messy and quite avoidable.
Fixed Issues (if relevant)
N/A
Manual testing scenarios (*)
Contribution checklist (*)