Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue fixed #20919 Email label and email field not aligned from left … #21009

Merged
merged 2 commits into from
Feb 14, 2019
Merged

issue fixed #20919 Email label and email field not aligned from left … #21009

merged 2 commits into from
Feb 14, 2019

Conversation

cedarvinda
Copy link
Member

…for reorder of guest user

issue fixed #20919 Email label and email field not aligned from left for reorder of guest user

Manual testing scenarios (*)

  1. Open frontend and order an product as guest customer
  2. open admin panel, open order grid from sales > order
  3. edit same order whatever you purchase
  4. click on reorder button
  5. page will open and will get issue ref screenshot

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

…for reorder of guest user

issue fixed #20919 Email label and email field not aligned from left for reorder of guest user
@magento-engcom-team
Copy link
Contributor

Hi @cedarvinda. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@dmytro-ch
Copy link
Contributor

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, here is your new Magento instance.
Admin access: https://pr-21009.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@dmytro-ch
Copy link
Contributor

Hi @cedarvinda, thank you for your contribution!
Could you please fix the issues mentioned in the review?

@cedarvinda
Copy link
Member Author

@dmytro-ch Thankyou. Sure ..

_order-account.less updated
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-4154 has been created to process this Pull Request

@ghost
Copy link

ghost commented Feb 14, 2019

Hi @cedarvinda, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment