Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Luma theme my account Order status tabs 21070 #21071

Merged

Conversation

abrarpathan19
Copy link
Contributor

@abrarpathan19 abrarpathan19 commented Feb 8, 2019

Description (*)

Fixed Luma theme my account Order status tabs

Fixed Issues (if relevant)

  1. Luma theme my account Order Information status tabs break in tablet view #21070:Luma theme my account Order Information status tabs break in tablet view

Manual testing scenarios (*)

  1. Place new order -> My account -> My orders -> select any order -> View Order -> see the order status tabs are breaking. see the attached screenshots
  2. It will happen when we will create a cash memo from admin for the order.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @abrarpathan19. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@dmytro-ch
Copy link
Contributor

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, here is your new Magento instance.
Admin access: https://pr-21071.instances.magento-community.engineering/admin
Login: admin Password: 123123q

Code refactoring, remove the redundant rules
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-4197 has been created to process this Pull Request

@sivaschenko sivaschenko changed the base branch from 2.3-develop to 2.2-develop February 14, 2019 13:31
@sivaschenko sivaschenko changed the base branch from 2.2-develop to 2.3-develop February 14, 2019 13:31
@ghost
Copy link

ghost commented Feb 14, 2019

Hi @abrarpathan19, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants