Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't scroll in modal popup on i os #21150

Merged
merged 4 commits into from
Apr 28, 2019
Merged

Can't scroll in modal popup on i os #21150

merged 4 commits into from
Apr 28, 2019

Conversation

priti2jcommerce
Copy link
Contributor

Description (*)

Fixed Issues (if relevant)

  1. Can't scroll in modal-popup on iOS #21147: Can't scroll in modal-popup on iOS
  2. ...

Manual testing scenarios (*)

  1. Try to scrolling in the popup on an iPhone (tested on iPhone 6s Plus & iPhone X)
  2. ...

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @priti2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@priti2jcommerce
Copy link
Contributor Author

@magento-engcom-team
Copy link
Contributor

Hi @priti2jcommerce. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @priti2jcommerce, here is your new Magento instance.
Admin access: https://pr-21150.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@Karlasa Karlasa self-assigned this Feb 12, 2019
Karlasa
Karlasa suggested changes Feb 12, 2019
View reviewed changes
Copy link
Contributor

@Karlasa Karlasa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@priti2jcommerce
Thanks for your fix. Your PR basically reverts PR #16664
So could be make both fixes work at the same time :)
I would suggest to not remove "pointer-events: none;" but just move it under media min @screen__m so closing modal on clicking outside of popup could work on tablet/desktop.

Cheers,

@priti2jcommerce
Copy link
Contributor Author

priti2jcommerce commented Feb 13, 2019 •
edited
Loading

Hi @Karlasa

Thanks for the update, made the changes for it.

@Karlasa
Copy link
Contributor

Karlasa commented Feb 13, 2019

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @Karlasa. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @Karlasa, here is your new Magento instance.
Admin access: https://pr-21150.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@Karlasa
Copy link
Contributor

Karlasa commented Feb 13, 2019

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @Karlasa. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @Karlasa, here is your Magento instance.
Admin access: https://i-21150-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@Karlasa
Copy link
Contributor

Karlasa commented Feb 13, 2019

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @Karlasa. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @Karlasa, here is your new Magento instance.
Admin access: https://pr-21150.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@Karlasa
Copy link
Contributor

Karlasa commented Feb 14, 2019

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @Karlasa. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @Karlasa, here is your new Magento instance.
Admin access: https://pr-21150.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@dmytro-ch
Copy link
Contributor

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, here is your new Magento instance.
Admin access: https://pr-21150.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@magento-engcom-team
Copy link
Contributor

Hi @Karlasa, thank you for the review.
ENGCOM-4261 has been created to process this Pull Request

@ghost ghost unassigned Karlasa and soleksii Apr 4, 2019
@sidolov
Copy link
Contributor

sidolov commented Apr 10, 2019

Hi @priti2jcommerce looks like you made some commits with email different than in your GitHub profile, please, add email from commits to your profile!
Thank you!

@priti2jcommerce
Copy link
Contributor Author

Hi @sidolov ,

committed changes from GitHub profile are here
Can you please confirm?
Thanks!

@ghost ghost assigned sidolov Apr 17, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-4775 has been created to process this Pull Request

@soleksii soleksii self-assigned this Apr 18, 2019
@soleksii
Copy link

✔️ QA Passed

Before:

before

After:

after

@p-bystritsky p-bystritsky self-assigned this Apr 18, 2019
@p-bystritsky p-bystritsky removed their assignment Apr 25, 2019
@nmalevanec nmalevanec self-assigned this Apr 25, 2019
@magento-engcom-team magento-engcom-team mentioned this pull request Apr 28, 2019
Closed
@magento-engcom-team magento-engcom-team merged commit ee8778b into magento:2.3-develop Apr 28, 2019
@m2-assistant
Copy link

m2-assistant bot commented Apr 28, 2019

Hi @priti2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.2 milestone Apr 28, 2019
magento-engcom-team pushed a commit that referenced this pull request Apr 28, 2019
@sivaschenko
ENGCOM-4775: Can't scroll in modal popup on i os #21150
569819a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Karlasa Karlasa Karlasa approved these changes

@sidolov sidolov sidolov approved these changes

Assignees

@sivaschenko sivaschenko

@sidolov sidolov

@nmalevanec nmalevanec

@soleksii soleksii

Labels
Area: Design/Frontend Award: bug fix Partner: Two Jay partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.2
Development

Successfully merging this pull request may close these issues.
10 participants
@priti2jcommerce @magento-engcom-team @Karlasa @dmytro-ch @soleksii @magento-cicd2 @sidolov @sivaschenko @nmalevanec @p-bystritsky