Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#21789 Fix gallery event observer #21790

Merged
merged 2 commits into from
Apr 9, 2019
Merged

#21789 Fix gallery event observer #21790

merged 2 commits into from
Apr 9, 2019

Conversation

Den4ik
Copy link
Contributor

@Den4ik Den4ik commented Mar 16, 2019 •
edited
Loading

Description (*)

This PR fix issue of opening gallery if moving mouse to image when clicking to another element of page

Fixed Issues (if relevant)

  1. [BUG] Product gallery opening by mistake #21789: [BUG] Product gallery opening by mistake

Manual testing scenarios (*)

  1. Open product page
  2. Click to product qty move cursor to product image and up mouse button

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @Den4ik. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@ghost ghost assigned sivaschenko Mar 16, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-4511 has been created to process this Pull Request

@shikhamis11
Copy link
Member

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @shikhamis11. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @shikhamis11, here is your new Magento instance.
Admin access: https://pr-21790.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@VasylShvorak VasylShvorak self-assigned this Mar 19, 2019
@VasylShvorak
Copy link
Contributor

✔️ QA passed

@nmalevanec nmalevanec self-assigned this Mar 19, 2019
@VladimirZaets VladimirZaets self-assigned this Mar 22, 2019
@VladimirZaets VladimirZaets self-requested a review March 22, 2019 18:51
@VladimirZaets
Copy link
Contributor

Hi @Den4ik. Thanks for collaboration.
Currently, we support IE 11 browser that not good supports ES6 features.

We can't add es6 to eslint cause it's will mean that we fully support ES6 but currently, it isn't.
Let and const declaration are already supported by IE11, but again, we should use all features of ES6 or don't use anything.

@ghost
Copy link

ghost commented Mar 22, 2019

Hi @Den4ik, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@Den4ik Den4ik mentioned this pull request Mar 23, 2019
Closed
4 tasks
@Den4ik
Copy link
Contributor Author

Den4ik commented Mar 23, 2019 •
edited
Loading

@VladimirZaets Can you please comment this file https://github.com/magento/magento2/blob/2.3-develop/app/code/Magento/Rule/view/adminhtml/web/rules.js#L302

@Den4ik Den4ik reopened this Mar 23, 2019
@ghost ghost unassigned sivaschenko and VladimirZaets Mar 23, 2019
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-4596 has been created to process this Pull Request

@VasylShvorak VasylShvorak self-assigned this Mar 29, 2019
@VasylShvorak
Copy link
Contributor

Hi @Den4ik Could you resolve conflicting files with 2.3-develop?

@Den4ik
Copy link
Contributor Author

Den4ik commented Apr 1, 2019 •
edited
Loading

@VasylShvorak Resolved

@ghost ghost assigned sivaschenko Apr 1, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-4596 has been created to process this Pull Request

@VasylShvorak
Copy link
Contributor

✔️ QA passed

@nmalevanec nmalevanec self-assigned this Apr 3, 2019
@magento-engcom-team magento-engcom-team mentioned this pull request Apr 9, 2019
Closed
@magento-engcom-team magento-engcom-team merged commit 55d5daa into magento:2.3-develop Apr 9, 2019
@m2-assistant
Copy link

m2-assistant bot commented Apr 9, 2019

Hi @Den4ik, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Apr 9, 2019
@sivaschenko
ENGCOM-4596: #21789 Fix gallery event observer #21790
1e111b5
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.2 milestone Apr 9, 2019
@Den4ik Den4ik deleted the fotorama-gallery-js branch April 9, 2019 19:14
This was referenced Apr 9, 2019
Merged
Merged
Eayshwary added a commit to Eayshwary/devdocs that referenced this pull request Jun 27, 2019
@Eayshwary
Changed OVE to OVER ( it was confusing )
239e3af 
<!--- ENGCOM-4596-->
* Product gallery images no longer open unexpectedly when you move *ove* a product image while moving to another page element. *Fix submitted by [Denis Kopylov ](https://github.com/Den4ik) in pull request [21790](magento/magento2#21790. [GitHub-21789](magento/magento2#21789)
@Eayshwary Eayshwary mentioned this pull request Jun 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sivaschenko sivaschenko sivaschenko approved these changes

@VladimirZaets VladimirZaets VladimirZaets approved these changes

Assignees

@sivaschenko sivaschenko

@VladimirZaets VladimirZaets

@nmalevanec nmalevanec

@VasylShvorak VasylShvorak

Labels
Area: Lib/Frontend Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.2
Development

Successfully merging this pull request may close these issues.
8 participants
@Den4ik @magento-engcom-team @shikhamis11 @VasylShvorak @VladimirZaets @sivaschenko @sidolov @nmalevanec