-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove @SuppressWarnings and optimize imports on Category View #22074
Remove @SuppressWarnings and optimize imports on Category View #22074
Conversation
Hi @arnoudhgz. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
Hi @arnoudhgz. Thank you for the refactoring. Please note that the unit tests should be adjusted correspondingly |
c1c6dd2
to
a24b8c1
Compare
@rogyar thank you for your feedback, I have overlooked this.. Will look into it asap |
Two @SuppressWarnings could be removed by splitting up the execute method by moving logic to separate private methods. Also the imports of this file are improved.
a24b8c1
to
999766c
Compare
@rogyar should I also look into the Codacy thing? It is actually not a new issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arnoudhgz Codacy can be safely ignored in general (and I don't see what could be a better name here particularly).
Hi @orlangur, thank you for the review. |
✔️ QA passed |
Hi @arnoudhgz, thank you for your contribution! |
Description
Two @SuppressWarnings could be removed by splitting up the execute
method by moving logic to separate private methods.
Also the imports of this file are improved.
Manual testing scenarios
Contribution checklist