-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed assignment of the guest customer to the guest group when 'Automatic Assignment by VAT ID' is enabled #22091
Fixed assignment of the guest customer to the guest group when 'Automatic Assignment by VAT ID' is enabled #22091
Conversation
This commit fixes the case when guest fills in valid VAT number, then returns to the shipping step and removes VAT from the address.
Hi @vovayatsyuk. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
@magento-engcom-team give me test instance |
Hi @rogyar. Thank you for your request. I'm working on Magento instance for you |
Hi @rogyar, here is your new Magento instance. |
Hi @rogyar, thank you for the review. |
✔️ QA passed |
Hi @vovayatsyuk, thank you for your contribution! |
…p when 'Automatic Assignment by VAT ID' is enabled #22091
Description
Current logic doesn't work for a guest group id since it's
0
.This commit fixes the case when guest fills valid VAT number,
then returns to the shipping step and removes VAT from the address.
Manual testing scenarios
quote
DB table using adminer of phpmyadmin, find your quote and look at thecustomer_group_id
column. You'll see id of valid group (4
, for example).quote
table again. I'm expecting to see0
here but it still has4
.Contribution checklist