Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #12802 - allow to override preference over CartInterface and return correct object from QuoteRepository #22149

Merged
merged 3 commits into from
Apr 29, 2019
Merged

Fix #12802 - allow to override preference over CartInterface and return correct object from QuoteRepository #22149

merged 3 commits into from
Apr 29, 2019

Conversation

Bartlomiejsz
Copy link
Contributor

@Bartlomiejsz Bartlomiejsz commented Apr 3, 2019 •
edited
Loading

Description (*)

This is fix for #12802

Fixed Issues (if relevant)

  1. QuoteRepository get methods won't return CartInterface but Quote model #12802: QuoteRepository get methods won't return CartInterface but Quote model

Manual testing scenarios (*)

Steps are described in #12802

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 3, 2019

Hi @Bartlomiejsz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

orlangur
orlangur requested changes Apr 3, 2019
View reviewed changes
Copy link
Contributor

@orlangur orlangur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice @Bartlomiejsz!

According to my understanding such change is backward compatible, asking @sivaschenko to double check.

Please mark quoteFactory property as deprecated.

After changes are applied and all builds are green, please squash them into a single commit so that we have perfectly clean history 😉

app/code/Magento/Quote/Model/QuoteRepository.php Outdated Show resolved Hide resolved
@ghost ghost assigned orlangur Apr 3, 2019
@Bartlomiejsz Bartlomiejsz force-pushed the feature/fix_12802_quote_not_overridable branch 2 times, most recently from 5ae1e42 to 4430f64 Compare April 4, 2019 03:46
@Bartlomiejsz Bartlomiejsz requested a review from orlangur April 4, 2019 03:51
sivaschenko
sivaschenko requested changes Apr 4, 2019
View reviewed changes
Copy link
Member

@sivaschenko sivaschenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Bartlomiejsz thanks for the pull request, please see my review comment

app/code/Magento/Quote/Model/QuoteRepository.php Outdated Show resolved Hide resolved
@ghost ghost assigned sivaschenko Apr 4, 2019
orlangur
orlangur requested changes Apr 4, 2019
View reviewed changes
Copy link
Contributor

@orlangur orlangur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After changes are applied and all builds are green, please squash them into a single commit so that we have perfectly clean history 😉

app/code/Magento/Quote/Model/QuoteRepository.php Outdated Show resolved Hide resolved
@Bartlomiejsz
Fix magento#12802 - allow to override preference over \Magento\Quote\…
865d7df 
…Api\Data\CartInterface and return correct object from QuoteRepository (+4 squashed commits)

Squashed commits:
[55b9f3ec52b] Fix magento#12802 - fix phpmd, mark quoteFactory as deprecated
[56ca9a42468] Fix magento#12802 - change condition in quoteRepository
[734212812a4] Fix magento#12802 - revert change of constructor parameters names
[ba8ad543e0f] Fix magento#12802 - remove instanceof condition
@Bartlomiejsz Bartlomiejsz force-pushed the feature/fix_12802_quote_not_overridable branch from ba8ad54 to 865d7df Compare April 5, 2019 09:48
@Bartlomiejsz
Copy link
Contributor Author

@orlangur commits are squashed now

@Bartlomiejsz Bartlomiejsz requested a review from orlangur April 5, 2019 09:56
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-4679 has been created to process this Pull Request

@nmalevanec nmalevanec self-assigned this Apr 16, 2019
@magento-engcom-team magento-engcom-team mentioned this pull request Apr 29, 2019
Closed
@magento-engcom-team magento-engcom-team merged commit fa5cf90 into magento:2.3-develop Apr 29, 2019
@m2-assistant
Copy link

m2-assistant bot commented Apr 29, 2019

Hi @Bartlomiejsz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Apr 29, 2019
@sivaschenko
ENGCOM-4679: Fix #12802 - allow to override preference over CartInter…
bf616d2 
…face and return correct object from QuoteRepository #22149
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.2 milestone Apr 29, 2019
This was referenced Apr 29, 2019
Closed
Merged
@Bartlomiejsz Bartlomiejsz deleted the feature/fix_12802_quote_not_overridable branch August 25, 2019 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sivaschenko sivaschenko sivaschenko requested changes

@orlangur orlangur orlangur approved these changes

Assignees

@orlangur orlangur

@sivaschenko sivaschenko

@nmalevanec nmalevanec

Labels
Component: Quote Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.2
Development

Successfully merging this pull request may close these issues.
5 participants
@Bartlomiejsz @magento-engcom-team @orlangur @sivaschenko @nmalevanec