Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unregister phar only when appropriate #22171

Merged
merged 1 commit into from
Apr 15, 2019

Conversation

adaudenthun
Copy link
Contributor

Calling stream_wrapper_unregister('phar') without checking if it's registered will trigger a warning

Link issue : #21973

@m2-assistant
Copy link

m2-assistant bot commented Apr 5, 2019

Hi @adaudenthun. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@adaudenthun
Copy link
Contributor Author

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @adaudenthun. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @adaudenthun, here is your new Magento instance.
Admin access: https://pr-22171.instances.magento-community.engineering/admin
Login: admin Password: 123123q

app/bootstrap.php Outdated Show resolved Hide resolved
Calling stream_wrapper_unregister('phar') without checking if it's registered will trigger a warning
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-4681 has been created to process this Pull Request

@m2-assistant
Copy link

m2-assistant bot commented Apr 15, 2019

Hi @adaudenthun, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants