Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Turn on edit mode for product repository when adding children #22295

Conversation

amol2jcommerce
Copy link
Contributor

Original Pull Request

#21083

Description (*)

This should fix the issue with the configurable products not having any options with Bulk and Async API. The product was being cached and its extension attributes were empty when trying to add children to a product via Bulk API.

Fixed Issues (if relevant)

  1. The parent product doesn't have configurable product options. #20366: The parent product doesn't have configurable product options

Manual testing scenarios (*)

  1. Install Magento 2.3 with RabbitMQ
  2. Add Sample data
  3. Follow https://devdocs.magento.com/guides/v2.3/rest/tutorials/bulk-configurable-product/config-product-intro.html
  4. If this fix is not there, when you do the step to add the product children, an error is produced saying that the product does not contain any configurable options.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

pedrosousa13 and others added 3 commits April 12, 2019 04:56
This should fix the issue with the configurable products not having any options with Bulk and Async API.
Related issue: magento#20366
@m2-assistant
Copy link

m2-assistant bot commented Apr 12, 2019

Hi @amol2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

/**
* Configurable product link management.
*
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. Could you explain, please, why do we need @SuppressWarnings directive here? I understand that we have it in the original PR. However, we don't introduce a new dependency here and using this directive is a bit doubtful.

@ghost ghost assigned rogyar Apr 12, 2019
Copy link
Contributor

@orlangur orlangur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rogyar I believe this is due to new exception classes added.

@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-4754 has been created to process this Pull Request

@soleksii
Copy link

✔️ QA Passed

@m2-assistant
Copy link

m2-assistant bot commented Apr 18, 2019

Hi @amol2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.2.9 milestone Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants