-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport] Turn on edit mode for product repository when adding children #22295
[Backport] Turn on edit mode for product repository when adding children #22295
Conversation
This should fix the issue with the configurable products not having any options with Bulk and Async API. Related issue: magento#20366
Hi @amol2jcommerce. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
/** | ||
* Configurable product link management. | ||
* | ||
* @SuppressWarnings(PHPMD.CouplingBetweenObjects) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi. Could you explain, please, why do we need @SuppressWarnings
directive here? I understand that we have it in the original PR. However, we don't introduce a new dependency here and using this directive is a bit doubtful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rogyar I believe this is due to new exception classes added.
Hi @orlangur, thank you for the review. |
✔️ QA Passed |
Hi @amol2jcommerce, thank you for your contribution! |
Original Pull Request
#21083
Description (*)
This should fix the issue with the configurable products not having any options with Bulk and Async API. The product was being cached and its extension attributes were empty when trying to add children to a product via Bulk API.
Fixed Issues (if relevant)
Manual testing scenarios (*)
Contribution checklist (*)