#21747 Fix catalog_product_flat_data attribute value for store during indexer

[Bravarg]

Fix catalog_product_flat store tables values

Description (*)

Fix bin/magento indexer:reindex of catalog_product_flat for specified empty attribute value of exact store

Fixed Issues (if relevant)

1. catalog_product_flat_data for store view populated with default view data when it should be store view data #21747: catalog_product_flat_data for store view populated with default view data when it should be store view data

Manual testing scenarios (*)

1. Create custom attribute with scope "Store" or "Website", add it to attribute set.
2. Create a product and assign this attribute to Default scope.
3. Enable "Use Flat Catalog Product" settings.
4. Change scope to store-view of website and assign empty value, save product.
5. In database table catalog_product_flat_1 product has properly attribute value.
6. Run bin/magento indexer:reindex catalog_product_flat. In table catalog_product_flat_1 value or new attribute is set to default scope.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[m2-assistant]

Hi @OlehWolf. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[magento-engcom-team]

Hi @sivaschenko, thank you for the review.
ENGCOM-4749 has been created to process this Pull Request

[soleksii]

✔️ QA Passed

[m2-assistant]

Hi @OlehWolf, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[kilis]

I would like to report issue still persists on versions 2.2.10 and 2.3.2, before changes on these version all worked fine. This performance upgrade in this commit ac6512c reverted this problem back.