Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spelling Mistake in Setup > Patch #22339

Merged
merged 3 commits into from
Apr 20, 2019
Merged

Spelling Mistake in Setup > Patch #22339

merged 3 commits into from
Apr 20, 2019

Conversation

sudhanshu-bajaj
Copy link
Contributor

@sudhanshu-bajaj sudhanshu-bajaj commented Apr 15, 2019 •
edited
Loading

Description (*)

Spelling mistake in Patch

Fixed Issues (if relevant)

  1. magento/magento2#<issue_number>: Issue title

Manual testing scenarios (*)

  1. N/A

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 15, 2019

Hi @sudhanshu-bajaj. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@ghost ghost assigned orlangur Apr 15, 2019
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-4758 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@sudhanshu-bajaj thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@sudhanshu-bajaj
Copy link
Contributor Author

@orlangur Any idea why this failed "The Travis CI build failed" ?

@m2-assistant
Copy link

m2-assistant bot commented Apr 16, 2019

Hi @sudhanshu-bajaj, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost unassigned orlangur Apr 16, 2019
@sudhanshu-bajaj sudhanshu-bajaj self-assigned this Apr 16, 2019
@ghost ghost unassigned sudhanshu-bajaj Apr 16, 2019
@ghost
Copy link

ghost commented Apr 16, 2019

@sudhanshu-bajaj unfortunately, only members of the maintainers team are allowed to assign developers to the pull request

@sudhanshu-bajaj sudhanshu-bajaj self-assigned this Apr 16, 2019
@ghost ghost unassigned sudhanshu-bajaj Apr 16, 2019
@ghost
Copy link

ghost commented Apr 16, 2019

@sudhanshu-bajaj unfortunately, only members of the maintainers team are allowed to assign developers to the pull request

@ghost ghost assigned ihor-sviziev Apr 16, 2019
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-4765 has been created to process this Pull Request

@VasylShvorak VasylShvorak self-assigned this Apr 17, 2019
@VasylShvorak
Copy link
Contributor

Notice: QA not applicable

@p-bystritsky p-bystritsky self-assigned this Apr 18, 2019
@magento-engcom-team magento-engcom-team merged commit 432334e into magento:2.3-develop Apr 20, 2019
@m2-assistant
Copy link

m2-assistant bot commented Apr 20, 2019

Hi @sudhanshu-bajaj, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Apr 20, 2019
@sidolov
ENGCOM-4765: Spelling Mistake in Setup > Patch #22339
6f24b51
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.2 milestone Apr 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orlangur orlangur orlangur approved these changes

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

Assignees

@orlangur orlangur

@ihor-sviziev ihor-sviziev

@p-bystritsky p-bystritsky

@VasylShvorak VasylShvorak

Labels
Cleanup Component: Setup Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.2
Development

Successfully merging this pull request may close these issues.
7 participants
@sudhanshu-bajaj @magento-engcom-team @VasylShvorak @orlangur @ihor-sviziev @p-bystritsky @bajaj-sudhanshu