apply_to fix #466
Closed
apply_to fix #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 9, 2014 13:15
if one of the fields apply_to is null here (which means it applies to all products) it was getting set to only apply to downloadable products. I saw this specifically with the cost attribute.
| $applyTo = explode(',', $installer->getAttribute(\Magento\Catalog\Model\Product::ENTITY, $field, 'apply_to')); | ||
| if (!in_array('bundle', $applyTo)) { | ||
| $applyToStr = $installer->getAttribute(Mage_Catalog_Model_Product::ENTITY, $field, 'apply_to'); | ||
| $applyTo = explode(',', $applyToStr); |
There was a problem hiding this comment.
One more tab will be good here :)
|
Hello @jason-neumann , the team looked at the issue and asked to update the description for the issue. Could you please extend on the description of the issue you try to solve with this pull request? Thank you! |
|
@jason-neumann, the team has finished reviewing the case you reported. Here is the response:
Basing on this, we cannot accept your contribution. We are closing this pull request. |
magento-team
pushed a commit
that referenced
this pull request
Mar 21, 2016
…rid-of-helpers [Extensibility] MAGETWO-50209: Get rid of Helpers in Password Security Management
mmansoor-magento
pushed a commit
that referenced
this pull request
Oct 6, 2016
[South] Bug fixes - MAGETWO-56529 Magento\Framework\Session\SaveHandlerTest test failed - MAGETWO-55794 [FT] Product is not assigned to category - MAGETWO-56370 [GITHUB] Broken File Type Custom Option #5434 - MAGETWO-59146 [Github] Disable email communication set to yes: email did get sent. #5988 - MAGETWO-56871 [GITHUB] Non-admin do not have permission to search for Categories in Cart Price Rules #6168
magento-engcom-team
added a commit
that referenced
this pull request
Mar 13, 2019
- Merge Pull Request magento/graphql-ce#466 from yogeshsuhagiya/graphql-ce:2.3-develop-graphql-PR-yogesh-4 - Merged commits: 1. f406c28
magento-engcom-team
pushed a commit
that referenced
this pull request
Mar 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if one of the fields apply_to is null here (which means it applies to all products) it was getting set to only apply to downloadable products. I saw this specifically with the cost attribute.