Update universalWalletConnector to include switchChain method #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add localforage as dependency (required by @magic-sdk/provider) - Add changeset script for better version management
- Uncomment dist/**/* in .gitignore to match upstream - Will build dist/ during npm publish instead of committing it
Merge v2.1.1 from upstream - Sync with upstream v2.1.1 - Update Magic SDK dependencies - Preserve switchChain functionality - Add prepublishOnly script - Restore upstream .gitignore pattern
…sly, tho it seems it was not checked in), to disambiguate that this connector is for Magic wallet.
...that we used previously. This disambiguates that this is a wagmi connector for the Magic wallet.
joshuascan
requested changes
Jan 31, 2025
|
Hi @joshuascan, thanks so much for this! I believe we've made the changes you've requested. Please let us know if you need anything else! |
|
Thanks @ninemachines! I'll merge this now and will circle back shortly with the version number once it's been published. |
joshuascan
approved these changes
Feb 3, 2025
|
@robyn3choi / @ninemachines your changes have been released in version Thanks again for your contribution! |
|
Thanks so much, @joshuascan!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
connector.magic.wallet.showUI()from a React component and have it open the wallet on the newly switched chain)What is the current behavior? (You can also link to an open issue here)
switchChainwhen connected with the universal wallet connector does nothing - Can't switch chain with universalWalletConnector #22.**What is the new behavior (if this is a feature change)?
switchChainwhen connected with the universal wallet connector switches chains