Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes lost session #32

Merged
merged 4 commits into from
Nov 26, 2024
Merged

fixes lost session #32

merged 4 commits into from
Nov 26, 2024

Conversation

joshuascan
Copy link
Member

@joshuascan joshuascan commented Nov 26, 2024

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Bugfix.

  • What is the current behavior? (You can also link to an open issue here)

When refreshing the page after connecting, the wagmi connection returns false, causing it to appear as if a user is not authenticated. This was due to a misconfiguration in the order of operations within the isAuthorized method.

  • What is the new behavior (if this is a feature change)?

The dedicatedWalletConnector now properly sets the the oauth state within the isAuthorized method and calls the Magic methods in the correct order.

  • Other information:

Includes fixes for OAuth and close button sizing/placement.

Before:
Screenshot 2024-11-25 at 5 38 16 PM

After:
Screenshot 2024-11-25 at 5 13 51 PM

@joshuascan joshuascan marked this pull request as ready for review November 26, 2024 01:29
@joshuascan joshuascan requested a review from Ethella November 26, 2024 01:34
@joshuascan joshuascan merged commit 496d7e0 into main Nov 26, 2024
1 check passed
@joshuascan joshuascan deleted the PDEEXP-2080-fix-wagmi-integration branch November 26, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants