Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli): add support for bun package manager #422

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

Robert27
Copy link
Contributor

@Robert27 Robert27 commented Oct 30, 2024

Since yarn, npm and pnpm are already supported, I see no reason not to support bun.
I tested it via bun patch package and everything worked flawlessly. The magidoc generate was about twice as fast as with pnpm.

We use a bun only Dockerfile where there is no option to add node / npm just to build the docs.

@pelletier197
Copy link
Collaborator

Looks like a no brainier. Thank you for your contribution!

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 12.50000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 83.85%. Comparing base (f7bb3bd) to head (c90a7d3).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
packages/cli/src/node/packageManager.ts 12.50% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #422      +/-   ##
==========================================
- Coverage   84.05%   83.85%   -0.21%     
==========================================
  Files          93       93              
  Lines        2910     2917       +7     
  Branches      570      649      +79     
==========================================
  Hits         2446     2446              
- Misses        419      422       +3     
- Partials       45       49       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Robert27
Copy link
Contributor Author

Robert27 commented Nov 8, 2024

Thanks, I’ll try to improve the coverage later.

@pelletier197 pelletier197 merged commit 1ae29bc into magidoc-org:main Nov 8, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants