Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(carbon-template): add dark mode #423

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

Robert27
Copy link
Contributor

@Robert27 Robert27 commented Nov 2, 2024

  • added css overrides support dark mode docs
  • syncs with the device settings

Here's our demo version using the overrides deployed: https://api.dev.neuland.app/neuland-api

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.05%. Comparing base (f7bb3bd) to head (e3bc1fd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #423   +/-   ##
=======================================
  Coverage   84.05%   84.05%           
=======================================
  Files          93       93           
  Lines        2910     2910           
  Branches      570      596   +26     
=======================================
  Hits         2446     2446           
+ Misses        419      417    -2     
- Partials       45       47    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pelletier197
Copy link
Collaborator

pelletier197 commented Nov 8, 2024

Hey! Sorry for the late review. This is an awesome improvement. Tested it and everything works well.

Thanks a lot for that!

@pelletier197 pelletier197 merged commit 79fda1b into magidoc-org:main Nov 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants