Add tomcat9 module #378
Merged
Add tomcat9 module #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since tomcat9 requires java8, tests are disable for jdk < 1.8. In MemcachedSessionServiceTest at some places `requestId` was changed to be not null, since with source/target 1.8 (which was set initially) the `null` values caused `IllegalArgumentException`s in `LockingStrategy.onBackupWithoutLoadedSession` which requires it to be `NonNull`. Refs #365
…ionsWithNonStickySessions Failed here: https://travis-ci.org/magro/memcached-session-manager/jobs/355123287 `MemcachedClient#shutdown` is now invoked with a timeout, in order to await running operations. Maybe this helps to properly shutdown the memcached client.
kasecato
reviewed
Mar 19, 2018
|
|
||
| <profiles> | ||
| <profile> | ||
| <!-- tomcat9 requires java8, therefore we disable tests on java7 --> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In MemcachedSessionServiceTest at some places
requestIdwas changedto be not null, since with source/target 1.8 (which was set initially)
the
nullvalues causedIllegalArgumentExceptions inLockingStrategy.onBackupWithoutLoadedSessionwhich requires it to beNonNull.Refs #365