Skip to content

Commit

Permalink
geosolutions-it#9683: Resolve review comments
Browse files Browse the repository at this point in the history
Description:
- Reolve unused loading property from DashoardEditor file
- Add tooltip for save dashboard
- Remove custom style in BorderLayout and leave it with generic style
  • Loading branch information
mahmoudadel54 committed Nov 20, 2023
1 parent b737bd8 commit b0bad21
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 4 deletions.
1 change: 0 additions & 1 deletion web/client/components/layout/BorderLayout.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ export default ({id, children, header, footer, columns, height, style = {}, clas
width: "100%",
height: "100%",
overflow: "hidden",
paddingRight: "auto",
...style
}}>
{header}
Expand Down
4 changes: 1 addition & 3 deletions web/client/plugins/DashboardEditor.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ class DashboardEditorComponent extends React.Component {
static propTypes = {
id: PropTypes.string,
editing: PropTypes.bool,
loading: PropTypes.bool,
limitDockHeight: PropTypes.bool,
fluid: PropTypes.bool,
zIndex: PropTypes.number,
Expand All @@ -68,7 +67,6 @@ class DashboardEditorComponent extends React.Component {
id: "dashboard-editor",
editing: false,
dockSize: 500,
loading: true,
limitDockHeight: true,
zIndex: 10000,
fluid: false,
Expand Down Expand Up @@ -100,7 +98,7 @@ const Plugin = connect(
isDashboardEditing,
isDashboardLoading,
isDashboardAvailable,
(editing, loading, isDashboardOpened) => ({ editing, loading, isDashboardOpened })
(editing, isDashboardOpened) => ({ editing, isDashboardOpened })
), {
setEditing,
onMount: () => setEditorAvailable(true),
Expand Down
2 changes: 2 additions & 0 deletions web/client/plugins/DashboardSave.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ export const DashboardSave = createPlugin('DashboardSave', {
text: <Message msgId="save"/>,
icon: <Glyphicon glyph="floppy-open"/>,
action: triggerSave.bind(null, true),
tooltip: "saveDialog.saveTooltip",
// display the BurgerMenu button only if the map can be edited
selector: createSelector(
isLoggedIn,
Expand All @@ -84,6 +85,7 @@ export const DashboardSave = createPlugin('DashboardSave', {
text: <Message msgId="save"/>,
icon: <Glyphicon glyph="floppy-open"/>,
action: triggerSave.bind(null, true),
tooltip: "saveDialog.saveTooltip",
// display the BurgerMenu button only if the map can be edited
selector: createSelector(
isLoggedIn,
Expand Down

0 comments on commit b0bad21

Please sign in to comment.