include traefik-certs-dumper into the image #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- also fixed a small issue with readme file not updating correctly for gucci - natuarally updated versions of everything
2 tasks
|
LGTM, but I have a question: What about using it as an additional docker container like the example: https://github.com/ldez/traefik-certs-dumper/blob/master/docs/docker-compose-traefik-v2.yml? |
|
Not sure, my first reaction that it is more complex and may be more brittle. As a personal perference I do not like the idea of a container running forever (even if it sleeps most of the time) doing nothing 99.99% of the time. What advantages do you see? @SaraSmiseth |
SaraSmiseth
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to facilitate mailserver2/mailserver#62 see discussion there