[WEB-3356] chore: removed the project filter

[NarayanBavisetti]

Description

this pull request resolves the issue of the removal of issue relations in cross-project linking.

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• Feature (non-breaking change which adds functionality)
• Improvement (change that would cause existing functionality to not work as expected)
• Code refactoring
• Performance improvements
• Documentation update

Issue Link:- WEB-3356

Summary by CodeRabbit

• Refactor
  • Updated the issue relationship deletion process to support broader criteria, enabling removals across a wider range of contexts while continuing to deliver consistent success responses.

[coderabbitai]

Walkthrough

The changes modify the remove_relation method in the IssueRelationViewSet class. The filtering condition based on project_id has been removed from the query, thereby broadening the scope to match issue relations across projects. The filters on issue_id and related_issue_id remain, and the deletion process along with its logging and response (returning a 204 No Content status) is maintained without alterations.

Changes

File	Change Summary
apiserver/.../issue/relation.py	Removed the project_id filter from the remove_relation method; maintained filtering on issue_id and related_issue_id, with preserved deletion workflow.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant IssueRelationViewSet
    participant Database
    participant Logger

    Client->>IssueRelationViewSet: DELETE /issue_relation (issue_id, related_issue_id)
    IssueRelationViewSet->>Database: Query issue relations (with issue_id, related_issue_id)
    Database-->>IssueRelationViewSet: Return matching issue relation(s)
    IssueRelationViewSet->>Database: Delete matched issue relation
    IssueRelationViewSet->>Logger: Log deletion activity
    IssueRelationViewSet-->>Client: 204 No Content

Loading

Possibly related PRs

• [WEB-2504] chore: issue relation hard delete #5671 - Implements a hard delete functionality for issue relations by modifying the remove_relation method.
• [WEB-2935] fix: search issues endpoint #6291 - Alters the same method in the IssueRelationViewSet class, affecting the logic for retrieving and deleting issue relations.

Suggested labels

🐛bug

Suggested reviewers

• pablohashescobar
• sriramveeraghanta
• gurusainath

Poem

I'm a bouncy rabbit with code so neat,
Hopping through changes on a digital street.
I removed a filter to set data free,
Now issue relations connect effortlessly.
With a twitch of my nose and a joyful heart,
I celebrate clean code—a work of art!
🥕🐇

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6aa139a and 144d3a9.

📒 Files selected for processing (1)

• apiserver/plane/app/views/issue/relation.py (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: Analyze (javascript)
• GitHub Check: Analyze (python)

🔇 Additional comments (1)

apiserver/plane/app/views/issue/relation.py (1)

276-277: LGTM! The changes correctly enable cross-project issue relation deletion.

The removal of the project filter allows issue relations to be deleted across different projects within the same workspace, which aligns with the PR objective of fixing cross-project linking issues. The workspace-level security boundary is maintained through the workspace__slug filter.

Let's verify that the changes don't break any existing functionality:

✅ Verification successful

🏁 Script executed:

#!/bin/bash
# Description: Check for any potential issues with cross-project relations.

# Test 1: Check if there are any hardcoded project_id references in tests
echo "Checking for hardcoded project_id references in tests..."
rg -l "project_id.*remove_relation" "tests/"

# Test 2: Check if there are any other methods that might need similar changes
echo "Checking for similar patterns in other methods..."
ast-grep --pattern 'def remove_relation($$$)' 

Length of output: 371

---

Verification of Cross-Project Issue Relation Deletion

The gathered output confirms that:

• There are no hardcoded project_id references in test files (as no tests directory was found, which is expected either because tests are located elsewhere or filtering isn't required).
• No additional methods matching remove_relation indicate similar filtering dependencies.

The changes correctly remove the project filter while preserving the workspace-level security, aligning with the PR objective of enabling cross-project issue relation deletions without inadvertently affecting other functionality.

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.