fix(combobox): remove alwaysFilter option (#197)

makeup · Jan 17, 2025 · c84b6d4 · c84b6d4
1 parent 72b3adb
commit c84b6d4
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 12 deletions.
diff --git a/docs/ui/makeup-combobox/index.min.js b/docs/ui/makeup-combobox/index.min.js
diff --git a/docs/ui/makeup-combobox/index.min.js.map b/docs/ui/makeup-combobox/index.min.js.map
diff --git a/packages/ui/makeup-combobox/dist/cjs/index.js b/packages/ui/makeup-combobox/dist/cjs/index.js
@@ -11,8 +11,7 @@ const defaultOptions = {
   autoSelect: true,
   collapseTimeout: 150,
   customElementMode: false,
-  autoScroll: true,
-  alwaysFilter: true
+  autoScroll: true
 };
 class _default {
   constructor(widgetEl, selectedOptions) {
@@ -106,7 +105,9 @@ class _default {
 }
 exports.default = _default;
 function _onInputFocus() {
-  if (!this._options.alwaysFilter === true) {
+  if (this._autocompleteType === "list") {
+    _filterSuggestions(this._inputEl.value, this._listboxWidget.items);
+  } else {
     this.resetFilter();
   }
 }

diff --git a/packages/ui/makeup-combobox/dist/mjs/index.js b/packages/ui/makeup-combobox/dist/mjs/index.js
@@ -4,8 +4,7 @@ const defaultOptions = {
   autoSelect: true,
   collapseTimeout: 150,
   customElementMode: false,
-  autoScroll: true,
-  alwaysFilter: true
+  autoScroll: true
 };
 class index_default {
   constructor(widgetEl, selectedOptions) {
@@ -104,7 +103,9 @@ class index_default {
   }
 }
 function _onInputFocus() {
-  if (!this._options.alwaysFilter === true) {
+  if (this._autocompleteType === "list") {
+    _filterSuggestions(this._inputEl.value, this._listboxWidget.items);
+  } else {
     this.resetFilter();
   }
 }

diff --git a/packages/ui/makeup-combobox/src/index.js b/packages/ui/makeup-combobox/src/index.js
@@ -6,7 +6,6 @@ const defaultOptions = {
   collapseTimeout: 150,
   customElementMode: false,
   autoScroll: true,
-  alwaysFilter: true,
 };
 
 export default class {
@@ -123,7 +122,9 @@ export default class {
 }
 
 function _onInputFocus() {
-  if (!this._options.alwaysFilter === true) {
+  if (this._autocompleteType === "list") {
+    _filterSuggestions(this._inputEl.value, this._listboxWidget.items);
+  } else {
     this.resetFilter();
   }
 }