Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(active-desendant): item scroll when not in view #199

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Conversation

saiponnada
Copy link
Contributor

Fixes #198,

Following changes were implemented

  • Changed scroll behavior to smooth and set block:nearest
  • Also added another check to see if the intended scrollable element in view.

Other approaches discussed but not implemented are, to check if the listbox is in expanded state. This change might require a refactor and need to use listbox directly to benefit the change.

Copy link
Contributor

@LuLaValva LuLaValva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good change all around! I think this is the right solution

Copy link
Contributor

@agliga agliga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets see if this will work correctly. It looks like a good change, but I think it might not be fixing all of our usecases
Lets try it though

@saiponnada saiponnada merged commit 64355ba into master Jan 28, 2025
1 check passed
@saiponnada saiponnada deleted the scroll-fix branch January 28, 2025 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

listbox: page scrolls when listbox items are scrolled
4 participants