Skip to content

Commit

Permalink
fix: make deploy.kind didn't work, anymore.
Browse files Browse the repository at this point in the history
After kubernetes-retired#1306 has been
merged, `make deploy.kind` broke because it doesn't provide the
`KIND_CLUSTER_NAME` variable. An empty default provided to `kind`'s
`--name` parameter doesn't make much sense because `kind` will simply
error out in that case so using a default of `kind` for the name is
the solution that should work most of the time, especially when
following the quick start guide in the README.md.
  • Loading branch information
Max Jonas Werner committed Oct 22, 2020
1 parent 4ca58e7 commit c6ef890
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion scripts/deploy-kubefed.sh
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ fi
# Use KIND_LOAD_IMAGE=y ./scripts/deploy-kubefed.sh <image> to load
# the built docker image into kind before deploying.
if [[ "${KIND_LOAD_IMAGE:-}" == "y" ]]; then
kind load docker-image "${IMAGE_NAME}" --name="${KIND_CLUSTER_NAME:-}"
kind load docker-image "${IMAGE_NAME}" --name="${KIND_CLUSTER_NAME:-kind}"
fi

cd "$(dirname "$0")/.."
Expand Down

0 comments on commit c6ef890

Please sign in to comment.