Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YARA rule cleanup #3

Merged
merged 4 commits into from
Dec 4, 2018
Merged

YARA rule cleanup #3

merged 4 commits into from
Dec 4, 2018

Conversation

wesinator
Copy link
Contributor

@wesinator wesinator changed the title YARA rule fixes YARA rule cleanup Oct 30, 2018
@blacktop
Copy link
Member

blacktop commented Dec 2, 2018 •
edited
Loading

Hello, sorry for the delay, but why is it important that the descriptions be proper utf-8? It seems to not have an affect on the actual detection? I apologize if I am missing something.

@wesinator
Copy link
Contributor Author

Doesn't affect detection, just makes the file easier to edit in certain editors that don't support the encoding (gedit).

It also shows Chinese chars correctly, 5e43146#diff-47f2da197695b69ba377b17309eb8435R10794

@blacktop
Copy link
Member

blacktop commented Dec 4, 2018

I can dig it 👍

@blacktop blacktop merged commit 1972b7b into malice-plugins:master Dec 4, 2018
@wesinator wesinator deleted the peid-yara branch December 4, 2018 03:11
@wesinator wesinator mentioned this pull request May 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wesinator @blacktop