Juku E5101/E5104 into working machine status #9946
Open
+396
−124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
cuavas
requested changes
Jun 28, 2022
src/mame/juku/juku.cpp
Outdated
Comment on lines
307
to
393
| for (int y = 0; y < 240; y++) | ||
| for (int x = 0; x < 320; x++) | ||
| bitmap.pix(y, x) = BIT(m_ram[0xd800 + (y * (320 / 8) + x / 8)], 7 - (x % 8)) ? rgb_t::white() : rgb_t::black(); | ||
| for (int y = 0; y < m_screen_y; y++) | ||
| { | ||
| uint32_t *dest = &bitmap.pix(y); | ||
| for (int x = 0; x < m_screen_x; x++) | ||
| *dest++ = BIT(m_ram[0xd800 + (y * (m_screen_x / 8) + x / 8)], 7 - (x % 8)) ? rgb_t::white() : rgb_t::black(); | ||
| } |
There was a problem hiding this comment.
You should restrict drawing to the clipping rectangle, at least vertically.
There was a problem hiding this comment.
Why is that? It seems that clipping rectangle currently always coincides with the visible area, which is full screen of the emulated system.
startaq
requested changes
Jun 28, 2022
|
Updated and cleaned up the code and implemented most of the requested changes:
Splitting up the 1986 and 1988 versions seems to be a good next development. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added:
Fixed: