Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please include wheels for modern Pythons #125

Closed
jaraco opened this issue Feb 19, 2019 · 4 comments
Closed

Please include wheels for modern Pythons #125

jaraco opened this issue Feb 19, 2019 · 4 comments

Comments

@jaraco
Copy link
Contributor

jaraco commented Feb 19, 2019

It seems that pytest-virtualenv (and possibly other plugins) are released as Python 2 only wheels. I suspect these plugins are pure-python, version-agnostic packages, so wheels should be released as universal wheels.

Not releasing wheels means that a package must build the package from a source dist, which causes setup_requires=['setuptools-git'] to invoke easy_install, which fails on some builds of Python (including official builds of Python 3.5 for macOS, which were built against older versions of OpenSSL without TLS 1.2 support), so fail to load packages from PyPI via easy_install.

@quartox
Copy link

quartox commented Feb 28, 2019

Another solution (which might be simpler) would be to include a pyproject.toml (see pep 518) which allows pip to install setup_requires before opening the setup.py.

@jaraco
Copy link
Contributor Author

jaraco commented Feb 28, 2019

Yes. In my opinion, both should be done.

jcfr added a commit to jcfr/pytest-plugins that referenced this issue Mar 7, 2019
jcfr added a commit to jcfr/pytest-plugins that referenced this issue Mar 7, 2019
jcfr added a commit to jcfr/pytest-plugins that referenced this issue Mar 7, 2019
jcfr added a commit to jcfr/pytest-plugins that referenced this issue Mar 7, 2019
Wheel is currently considered the standard for built and binary
packaging for Python

See https://packaging.python.org/discussions/wheel-vs-egg/

See man-group#125
jcfr added a commit to jcfr/pytest-plugins that referenced this issue Mar 20, 2019
----
ci: Test against Python 3.7

----
ci: Skip Coveralls submission if COVERALLS_REPO_TOKEN env. var is empty

----
ci: Update circleci image to allow install of python 3.7
See https://circleci.com/docs/2.0/configuration-reference/#machine

----
pytest-server-fixture: Fix rethinkdb tests requiring rethinkdb < 2.4.0

The current implementation needs to be refactored to support the latest
release of rethinkdb-python package. See man-group#132

----
wheels: Generate universal wheels installable with both python 2.x and 3.x
See man-group#125

Fix DeprecationWarning warnings using "logger.warning()" function

----
pytest-virtualenv: Add virtualenv as install requirement. Fixes man-group#122

Remove requirement for pytest<4.0.0
See man-group#100

----
pytest-webdriver: Fix RemovedInPytest4Warning using getfixturevalue

This commit fixes the following error:

  >           root_uri.append(request.getfuncargvalue('pyramid_server').uri)
  E           RemovedInPytest4Warning: getfuncargvalue is deprecated, use getfixturevalue

  pytest_webdriver.py:62: RemovedInPytest4Warning

See man-group#100

----
pytest-verbose-parametrize: Add support for revamped marker infrastructure

This commit fixes tests failing with pytest > 4.0.0

----
pytest-verbose-parametrize: Fix integration tests to support pytest >= 4.1.0

This commit updates tests to support version of pytest with
pytest-dev/pytest@e9b2475e2 (Display actual test ids in `--collect-only`)

----
dist: Remove support for building and distributing *.egg files

Wheel is currently considered the standard for built and binary
packaging for Python

See https://packaging.python.org/discussions/wheel-vs-egg/

See man-group#125

----
VagrantFile: Install python 3.7 and initialize python 3.7 by default
jcfr added a commit to jcfr/pytest-plugins that referenced this issue Mar 20, 2019
----
ci: Test against Python 3.7

----
ci: Skip Coveralls submission if COVERALLS_REPO_TOKEN env. var is empty

----
ci: Update circleci image to allow install of python 3.7
See https://circleci.com/docs/2.0/configuration-reference/#machine

----
pytest-server-fixture: Fix rethinkdb tests requiring rethinkdb < 2.4.0

The current implementation needs to be refactored to support the latest
release of rethinkdb-python package. See man-group#132

----
wheels: Generate universal wheels installable with both python 2.x and 3.x
See man-group#125

Fix DeprecationWarning warnings using "logger.warning()" function

----
pytest-virtualenv: Add virtualenv as install requirement. Fixes man-group#122

Remove requirement for pytest<4.0.0
See man-group#100

----
pytest-webdriver: Fix RemovedInPytest4Warning using getfixturevalue

This commit fixes the following error:

  >           root_uri.append(request.getfuncargvalue('pyramid_server').uri)
  E           RemovedInPytest4Warning: getfuncargvalue is deprecated, use getfixturevalue

  pytest_webdriver.py:62: RemovedInPytest4Warning

See man-group#100

----
pytest-verbose-parametrize: Add support for revamped marker infrastructure

This commit fixes tests failing with pytest > 4.0.0

----
pytest-verbose-parametrize: Fix integration tests to support pytest >= 4.1.0

This commit updates tests to support version of pytest with
pytest-dev/pytest@e9b2475e2 (Display actual test ids in `--collect-only`)

----
dist: Remove support for building and distributing *.egg files

Wheel is currently considered the standard for built and binary
packaging for Python

See https://packaging.python.org/discussions/wheel-vs-egg/

See man-group#125

----
VagrantFile: Install python 3.7 and initialize python 3.7 by default
@eeaston
Copy link
Collaborator

eeaston commented Mar 20, 2019

Hi, we just merged #130 which should address this, we'll get a release out very soon thanks!

@eeaston
Copy link
Collaborator

eeaston commented May 28, 2019

Released in 1.7.0 - many apologies all for the delay in releasing to pypi.

@eeaston eeaston closed this as completed May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants