-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md for python3 on new macs using zsh as default #91
Open
rkoppula
wants to merge
1
commit into
master
Choose a base branch
from
rkoppula-patch-2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -83,6 +83,14 @@ mlflow_artifact []: | |
``` bash | ||
$ pip install cookiecutter | ||
``` | ||
If you are on the latest macOS with zsh as the default, you will need to install this using pip3. To do this, update your path variable first by adding the following to your ~/.zshrc. | ||
``` | ||
export PATH=/Users/jjovanovic/Library/Python/3.8/bin:$PATH | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. change There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. or better yet, change |
||
``` | ||
Now you can run the following command | ||
``` | ||
$ pip3 install cookicutter | ||
``` | ||
It is recommended to set up a central virtualenv or condaenv for cookiecutter and any other "system" wide Python packages you may need. | ||
3. Run the cookiecutter docker data science template to scaffold your new project: | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that the
pip
wrapper is being deprecated in some Python versions, we should probably make the install instructions more generic. According to the docs, cookiecutter should be installed withAnd it then says to add
~/.local/bin
to thePATH
variable, which is where Python binaries are now being installed by default. This should avoid the problem that this fix addresses. Unfortunately I can't test this myself, since my environment likely differs from a new machine setup.It's also probably not a good idea to assume where Python binaries will be installed on new machines in the future, particularly since the path recommended here is assuming a specific Python version (which is currently 2 minor releases behind the latest stable version).
Now that I'm thinking about it, we should probably just refer the user to the install instructions in the
cookiecutter
docs and avoid any responsibility here. 😛