Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump setuptools version on mac #35820

Closed
wants to merge 3 commits into from
Closed

Bump setuptools version on mac #35820

wants to merge 3 commits into from

Conversation

cailafinn
Copy link
Contributor

Description of work

Purpose of work
We don't think there's an ARM version of 47.0 on mac. So it's making the pull-requests build fall over.

Summary of work
Update this with the same version as we're using for the mac packages as the Visual studio issue that was the reason for keeping to 47 isn't a problem on macOS.

To test:

  1. Does it build?

There is no associated issue.

This does not require release notes because dev only


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review
  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Are the release notes saved in a separate file, using Issue or PR number for file name and in the correct location?
Functional Tests
  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@cailafinn cailafinn added High Priority An issue or pull request that if not addressed is severe enough to postponse a release. ISIS Team: LSS Issue and pull requests managed by the LSS subteam at ISIS ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS DevOps Issues and pull requests related to DevOps labels Jul 18, 2023
@cailafinn cailafinn added this to the Release 6.8 milestone Jul 18, 2023
@cailafinn cailafinn force-pushed the update-setuptools-mac branch from 497b033 to 78e9e37 Compare July 19, 2023 09:41
@MialLewis
Copy link
Contributor

Superseded by #35832

@MialLewis MialLewis closed this Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DevOps Issues and pull requests related to DevOps High Priority An issue or pull request that if not addressed is severe enough to postponse a release. ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS ISIS Team: LSS Issue and pull requests managed by the LSS subteam at ISIS
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants