Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InputPassword exposes passwords in console because of autocomplete #4564

Closed
j-pendlebury opened this issue Jul 25, 2023 · 2 comments
Closed

Comments

@j-pendlebury
Copy link

What package has an issue

@mantine/core

Describe the bug

When using InputPassword on Chrome, the password field with value gets exposed because of a Chrome "feature": https://www.chromium.org/developers/design-documents/create-amazing-password-forms.

Adding autocomplete prop to component solves the issue but this should probably be listed as a required prop in docs.

Screenshot 2023-07-25 at 11 07 22

What version of @mantine/hooks page do you have in package.json?

^6.0.14

If possible, please include a link to a codesandbox with the reproduced problem

No response

Do you know how to fix the issue

Yes

Are you willing to participate in fixing this issue and create a pull request with the fix

Yes

Possible fix

Add autocomplete: 'on' or autocomplete: 'off' to InputPassword component + include in docs.

@rtivital
Copy link
Member

You are welcome to submit a PR with a fix

rtivital added a commit that referenced this issue Sep 5, 2023
@rtivital
Copy link
Member

rtivital commented Sep 5, 2023

Fixed in 6.0.20

@rtivital rtivital closed this as completed Sep 5, 2023
arel pushed a commit to arel/mantine that referenced this issue Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants