showNotification doesn't support data-* attributes

[OrRosenblatt]

Dependencies check up

• I have verified that I use latest version of all @mantine/* packages

What version of @mantine/* packages do you have in package.json?

7.4.2

What package has an issue?

@mantine/notifications

What framework do you use?

Vite

In which browsers you can reproduce the issue?

Not applicable – issue is not related to the browser

Describe the bug

When passing data-* attributes to showNotification or notifications.show functions a TS error is thrown:

Argument of type '{ message: string; "data-<attribute>": string; }' is not assignable to parameter of type 'NotificationData'.
  Object literal may only specify known properties, and '"data-<attribute>"' does not exist in type 'NotificationData'.

Example:

See link below for example code.

If possible, include a link to a codesandbox with a minimal reproduction

https://codesandbox.io/p/sandbox/focused-moon-m85ccq

Possible fix

No response

Self-service

• I would be willing to implement a fix for this issue

[rtivital]

Fixed in 7.5.2

[twiddler]

This change breaks this (simplified) code:

import { NotificationData, notifications } from '@mantine/notifications'

type OneTimeNotificationProps = Omit<NotificationData, 'color'>

function showSuccessNotification(props: OneTimeNotificationProps) {
    notifications.show({ // Argument of type '{ color: "green"; icon: JSX.Element; }' is not assignable to parameter of type 'NotificationData'. Property 'message' is missing in type '{ color: "green"; icon: JSX.Element; }' but required in type 'NotificationData'. ts(2345)
        color: 'green',
        ...props,
    })
}

TypeScript can no longer infer OneTimeNotificationProps narrowly:

type OneTimeNotificationProps = {
    [x: string]: any;
    [x: number]: any;
}