Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabled TagsInput Pills can be removed #5959

Closed
1 of 2 tasks
snturk opened this issue Mar 20, 2024 · 1 comment
Closed
1 of 2 tasks

Disabled TagsInput Pills can be removed #5959

snturk opened this issue Mar 20, 2024 · 1 comment
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)

Comments

@snturk
Copy link
Contributor

snturk commented Mar 20, 2024 •
edited
Loading

Dependencies check up

  • I have verified that I use latest version of all @mantine/* packages

What version of @mantine/* packages do you have in package.json?

7.6.1

What package has an issue?

@mantine/core

What framework do you use?

Other, I will specify in the bug description

In which browsers you can reproduce the issue?

Chrome

Describe the bug

Disabled TagsInput pills can be removed by just clicking them on the side where the "cross" button appears when not disabled.

Example video on Mantine website:

Screen.Recording.2024-03-20.at.12.45.16.mov

If possible, include a link to a codesandbox with a minimal reproduction

No response

Possible fix

No response

Self-service

  • I would be willing to implement a fix for this issue
@Kenzo-Wada Kenzo-Wada mentioned this issue Mar 20, 2024
Closed
snturk added a commit to snturk/mantine that referenced this issue Mar 24, 2024
@snturk
[@mantine/core] Fix Pill to respect disabled state (mantinedev#5959)
2685bae
@snturk snturk mentioned this issue Mar 24, 2024
Closed
rtivital added a commit that referenced this issue Mar 26, 2024
@rtivital
[@mantine/core] Fix incorrect disabled prop handling in TagsInput a…
dc5ed3d 
…nd MultiSelect (#5959)
@rtivital rtivital added the Fixed patch Completed issues that will be published with next patch (1.0.X) label Mar 26, 2024
@rtivital
Copy link
Member

Fixed in 7.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)
Projects
None yet
Milestone
No milestone
2 participants
@rtivital @snturk