Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BarChart: vertical orientation calls valueFormatter on the wrong axis #6979

Closed
1 of 2 tasks
sedrik opened this issue Oct 15, 2024 · 2 comments
Closed
1 of 2 tasks

BarChart: vertical orientation calls valueFormatter on the wrong axis #6979

sedrik opened this issue Oct 15, 2024 · 2 comments
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)

Comments

@sedrik
Copy link

sedrik commented Oct 15, 2024

Dependencies check up

  • I have verified that I use latest version of all @mantine/* packages

What version of @mantine/* packages do you have in package.json?

7.13.2

What package has an issue?

@mantine/charts

What framework do you use?

create-react-app (CRA)

In which browsers you can reproduce the issue?

Not applicable – issue is not related to the browser

Describe the bug

When I change the orientation to vertical the valueFormatter is called on the wrong axis. So my series names get NaN values in the y axis.

If possible, include a link to a codesandbox with a minimal reproduction

https://codesandbox.io/p/sandbox/mantine-react-template-forked-ff7ncg

Possible fix

Currently I work around the issue by checking the type of the value in the valueFormatter and only formatting numbers.

Self-service

  • I would be willing to implement a fix for this issue
rtivital added a commit that referenced this issue Oct 16, 2024
…h `orientation="vertical"` in BarChart, AreaChart and LineChart components (#6979)
@rtivital rtivital added the Fixed patch Completed issues that will be published with next patch (1.0.X) label Oct 16, 2024
@rtivital
Copy link
Member

Fixed in 7.13.3

@sedrik
Copy link
Author

sedrik commented Oct 17, 2024

Thanks for the quick resolution. Mantine is awesome! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)
Projects
None yet
Development

No branches or pull requests

2 participants