-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
useLocalStorage and useSessionStorage missing dependencies #5910
Conversation
When key or other value is changed the value is not reloaded
What real problem do you have that this PR fixes? |
When key is changed the value is not loaded. |
fixes #5911 |
Thanks! |
@rtivital @israelins85 This PR broke all of our usages of it and thus can't update to 7.7.1. Would be nice in the future to show example code on what your issue was and why this would fix it. |
It would be reverted in next patch |
What's happened? |
https://codesandbox.io/p/sandbox/mantine-react-template-forked-wk42tp?file=%2Fsrc%2FApp.tsx%3A6%2C2 What's broken? |
I use localStorage to store data from many devices key is like |
@rtivital @israelins85 @gl3nn this also broke Mantine DataTable on Mantine 7.7.1, see this issue: icflorescu/mantine-datatable#564 😑 We're using the Would be nice to see #6019 pulled... |
I've reverted it, the fix will be available in next patch |
Fixes #5911