feat(anywidget): Hoist static assets (_esm, _css) to share among front-end widget instances #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
manzt
changed the title
manzt
changed the title
basnijholt
added a commit
to pipefunc/pipefunc
that referenced
this pull request
Nov 27, 2024
Will change it back once manzt/anywidget#628 is merged.
basnijholt
added a commit
to pipefunc/pipefunc
that referenced
this pull request
Nov 27, 2024
Will change it back once manzt/anywidget#628 is merged.
basnijholt
added a commit
to pipefunc/pipefunc
that referenced
this pull request
Nov 27, 2024
Will change it back once manzt/anywidget#628 is merged.
basnijholt
added a commit
to pipefunc/pipefunc
that referenced
this pull request
Nov 27, 2024
Will change it back once manzt/anywidget#628 is merged and manzt/anywidget#613 solved) Currently the tutorial page is 60 MB which is prohibitively large.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #613
This PR is brings up some challenges for the ecosystem as a whole. I'm very tempted to go forward with #579. That would allow us to avoid the complexity of needing to work with ipywidgets (handling the comm ourself and messages), but currently all the ipywidgets container classes (e.g.,
Box,HBox,VBox) do aninstanceof(widget, ipywidget.Widget)check. That means if we were to introduce a more minimal base class foranywidget.AnyWidget, they couldn't be used in those containers.