Avoid Number.isNaN

mapbox · Aug 9, 2019 · 4c078d9 · 4c078d9
1 parent add9a4d
commit 4c078d9
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/src/style-spec/util/get_type.js b/src/style-spec/util/get_type.js
@@ -1,8 +1,6 @@
 
 export default function getType(val) {
-    if (Number.isNaN(val)) {
-        return 'NaN';
-    } else if (val instanceof Number) {
+    if (val instanceof Number) {
         return 'number';
     } else if (val instanceof String) {
         return 'string';

diff --git a/src/style-spec/validate/validate_number.js b/src/style-spec/validate/validate_number.js
@@ -6,7 +6,11 @@ export default function validateNumber(options) {
     const key = options.key;
     const value = options.value;
     const valueSpec = options.valueSpec;
-    const type = getType(value);
+    let type = getType(value);
+
+    if (type === 'number' && value !== value) {
+        type = 'NaN';
+    }
 
     if (type !== 'number') {
         return [new ValidationError(key, value, `number expected, ${type} found`)];