Limit parallel image requests for raster performance #7497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asheemmamoowala
pushed a commit
that referenced
this pull request
Oct 31, 2018
* limit parallel image requests for raster performance * add a test for maxParallelImageRequests * fix flow
kkaefer
reviewed
Nov 5, 2018
| @@ -17,7 +18,8 @@ const config: Config = { | |||
| } | |||
| }, | |||
| REQUIRE_ACCESS_TOKEN: true, | |||
| ACCESS_TOKEN: null | |||
| ACCESS_TOKEN: null, | |||
| MAX_PARALLEL_IMAGE_REQUESTS: 16 | |||
There was a problem hiding this comment.
I had to pick a number anyway, and that's what OpenLayers defaults to — it seemed to work well in practice, so I left it at that. We can adjust the default if you think 16 isn't a good value.
5 tasks
|
So this one is a properly implemented cbb059f? And you are saying that the XHR overhead shouldn't make a difference after this? |
|
Ah, so this actually shipped with 0.51 but was missed out from the Changelog? |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7460, improving raster sources performance on big screens by setting a global limit on how many image requests can happen in parallel, and queueing all the rest.
Similarly to
workerCount, the PR exposes the limit asmapboxgl.maxParallelImageRequestswhich you can change (16by default).Launch Checklist
document any changes to public APIs(probably not worth publicly documenting?)post benchmark scoresbenchmarks don't exercise big-screen tile loading