v1.9.0-beta.1 #9417

ryanhamley · 2020-03-12T15:49:46Z

Launch Checklist

arindam1993 · 2020-03-12T15:51:19Z

CHANGELOG.md

+* Add changelog policy to contribution guidelines ([#9378](https://github.com/mapbox/mapbox-gl-js/pull/9378))
+* Reduce bundle size and improve visual quality of `showTileBoundaries` debug text ([#9267](https://github.com/mapbox/mapbox-gl-js/pull/9267))
+* Clarify differences in `symbol-sort-key` with and without overlap ([#9379](https://github.com/mapbox/mapbox-gl-js/pull/9379))
+* Add browser testing with Selenium/WebDriver ([#9245](https://github.com/mapbox/mapbox-gl-js/pull/9245))


Does this need changelong? I was thinking we can skip this

arindam1993 · 2020-03-12T15:53:21Z

CHANGELOG.md

+* Slightly improve GPU memory footprint ([#9377](https://github.com/mapbox/mapbox-gl-js/pull/9377))
+* Results from `queryRenderedFeatures` now have evaluated property values rather than raw expressions ([#9198](https://github.com/mapbox/mapbox-gl-js/pull/9198))
+* `LngLatBounds.extend` now accepts `LngLatLike` and `LngLatBoundsLike` as well. ([#9293](https://github.com/mapbox/mapbox-gl-js/pull/9293))
+* Clarify GeolocateControl interaction states ([#9324](https://github.com/mapbox/mapbox-gl-js/pull/9324))


This looks like a documentation change, do we want to state it in the changelog?

arindam1993 · 2020-03-12T15:56:41Z

CHANGELOG.md

+
+### 🐞 Bug fixes
+* Allow needle argument to `in` expression to be false ([#9295](https://github.com/mapbox/mapbox-gl-js/pull/9295))
+* Clear source tiles when removing a layer ([#9305](https://github.com/mapbox/mapbox-gl-js/pull/9305))


Looks like this isn't exactly describing the change.

Suggested change

* Clear source tiles when removing a layer ([#9305](https://github.com/mapbox/mapbox-gl-js/pull/9305))

* Fix exception thrown when trying to set feature-state for a layer that has been removed, fixes [#8634](https://github.com/mapbox/mapbox-gl-js/issues/8634). ([#9305](https://github.com/mapbox/mapbox-gl-js/pull/9305))

arindam1993 · 2020-03-12T15:57:24Z

CHANGELOG.md

+### 🍏 Improvements
+* Add changelog policy to contribution guidelines ([#9378](https://github.com/mapbox/mapbox-gl-js/pull/9378))
+* Reduce bundle size and improve visual quality of `showTileBoundaries` debug text ([#9267](https://github.com/mapbox/mapbox-gl-js/pull/9267))
+* Clarify differences in `symbol-sort-key` with and without overlap ([#9379](https://github.com/mapbox/mapbox-gl-js/pull/9379))


Also a docs change

arindam1993 · 2020-03-12T15:57:44Z

CHANGELOG.md

+* Introduce `within` expression ([#9352](https://github.com/mapbox/mapbox-gl-js/pull/9352))
+
+### 🍏 Improvements
+* Add changelog policy to contribution guidelines ([#9378](https://github.com/mapbox/mapbox-gl-js/pull/9378))


also a docs change

chloekraw · 2020-03-12T15:53:22Z

CHANGELOG.md

+### 🍏 Improvements
+* Add changelog policy to contribution guidelines ([#9378](https://github.com/mapbox/mapbox-gl-js/pull/9378))
+* Reduce bundle size and improve visual quality of `showTileBoundaries` debug text ([#9267](https://github.com/mapbox/mapbox-gl-js/pull/9267))
+* Clarify differences in `symbol-sort-key` with and without overlap ([#9379](https://github.com/mapbox/mapbox-gl-js/pull/9379))


nit: this was a documentation update. It probably doesn't need to be in the changelog, although I don't recall with the GL JS policy is

CHANGELOG.md

chloekraw · 2020-03-12T15:55:26Z

CHANGELOG.md

+* Add browser testing with Selenium/WebDriver ([#9245](https://github.com/mapbox/mapbox-gl-js/pull/9245))
+* Slightly improve GPU memory footprint ([#9377](https://github.com/mapbox/mapbox-gl-js/pull/9377))
+* Results from `queryRenderedFeatures` now have evaluated property values rather than raw expressions ([#9198](https://github.com/mapbox/mapbox-gl-js/pull/9198))
+* `LngLatBounds.extend` now accepts `LngLatLike` and `LngLatBoundsLike` as well. ([#9293](https://github.com/mapbox/mapbox-gl-js/pull/9293))


nit: As someone who's not familiar with these properties, the changelog entry alone doesn't tell me what benefit I now get from this change (this tells me what changed, not the impact)

chloekraw · 2020-03-12T15:56:25Z

CHANGELOG.md

+* Fix a rendering error for very old versions of Chrome (ca. 2016) where text would appear much bigger than intended ([#9349](https://github.com/mapbox/mapbox-gl-js/pull/9349))
+* Fix a bug where `icon-image` expression that evaluates to `''` produced a warning. ([#9380](https://github.com/mapbox/mapbox-gl-js/pull/9380))
+* Prevent exception resulting from `line-dash-array` of empty length ([#9385](https://github.com/mapbox/mapbox-gl-js/pull/9385))
+* Improve scaling of patterns used in `line-pattern` on all device resolutions and pixel ratios ([#9266](https://github.com/mapbox/mapbox-gl-js/pull/9266))


nit: since this entry starts with "Improve", it seems weird that it's not in the "Improvements" section. We could either change the verb or move the entry. I think this is also a pretty big fix and should be higher in order

chloekraw · 2020-03-12T15:56:45Z

CHANGELOG.md

+* Clear source tiles when removing a layer ([#9305](https://github.com/mapbox/mapbox-gl-js/pull/9305))
+* Fix a bug where maps were not displaying inside elements with `dir=rtl`. ([#9332](https://github.com/mapbox/mapbox-gl-js/pull/9332))
+* Fix a rendering error for very old versions of Chrome (ca. 2016) where text would appear much bigger than intended ([#9349](https://github.com/mapbox/mapbox-gl-js/pull/9349))
+* Fix a bug where `icon-image` expression that evaluates to `''` produced a warning. ([#9380](https://github.com/mapbox/mapbox-gl-js/pull/9380))


nit: Probably can be ordered lower

chloekraw · 2020-03-12T15:57:18Z

CHANGELOG.md

+* Fix a bug where `icon-image` expression that evaluates to `''` produced a warning. ([#9380](https://github.com/mapbox/mapbox-gl-js/pull/9380))
+* Prevent exception resulting from `line-dash-array` of empty length ([#9385](https://github.com/mapbox/mapbox-gl-js/pull/9385))
+* Improve scaling of patterns used in `line-pattern` on all device resolutions and pixel ratios ([#9266](https://github.com/mapbox/mapbox-gl-js/pull/9266))
+* Correctly adjust patterns added with `addImage(id, image, pixelRatio)` by the asset pixel ratio, not the device pixel ratio ([#9372](https://github.com/mapbox/mapbox-gl-js/pull/9372))


Recommend moving this higher in order

chloekraw · 2020-03-12T15:58:24Z

CHANGELOG.md

+
+## Features and improvements
+* Map API functions such as `easeTo` and `flyTo` now support `padding: PaddingOptions` which lets developers shift the center of perspective for a map when building floating sidebars ([#8638](https://github.com/mapbox/mapbox-gl-js/pull/8638))
+* Introduce `within` expression ([#9352](https://github.com/mapbox/mapbox-gl-js/pull/9352))


Why not add more detail about how within works? This seems to deviate from past changelog entries featuring new expressions

Also, a new expression should go above a new easeTo / flyTo option

chloekraw · 2020-03-12T15:59:47Z

CHANGELOG.md

+* Introduce `within` expression ([#9352](https://github.com/mapbox/mapbox-gl-js/pull/9352))
+
+### 🍏 Improvements
+* Add changelog policy to contribution guidelines ([#9378](https://github.com/mapbox/mapbox-gl-js/pull/9378))


This would be better as a sentence under the release, rather than as a changelog entry.

"With this release, we're adding a new changelog policy to our contribution guidelines." with a link to the actual guidelines or contribution guidelines

chloekraw · 2020-03-12T16:00:44Z

CHANGELOG.md

+
+### 🍏 Improvements
+* Add changelog policy to contribution guidelines ([#9378](https://github.com/mapbox/mapbox-gl-js/pull/9378))
+* Reduce bundle size and improve visual quality of `showTileBoundaries` debug text ([#9267](https://github.com/mapbox/mapbox-gl-js/pull/9267))


since this is a debug mode improvement, I think it can be moved lower

CHANGELOG.md

asheemmamoowala · 2020-03-12T15:53:17Z

CHANGELOG.md

+
+## Features and improvements
+* Map API functions such as `easeTo` and `flyTo` now support `padding: PaddingOptions` which lets developers shift the center of perspective for a map when building floating sidebars ([#8638](https://github.com/mapbox/mapbox-gl-js/pull/8638))
+* Introduce `within` expression ([#9352](https://github.com/mapbox/mapbox-gl-js/pull/9352))


Suggestion from @chloekraw at #9352 (comment):

Suggested change

* Introduce `within` expression ([#9352](https://github.com/mapbox/mapbox-gl-js/pull/9352))

* Add `within` expression for testing whether an evaluated feature lies within a given GeoJSON object ([#9352](https://github.com/mapbox/mapbox-gl-js/pull/9352)). For example:<br>

`"icon-opacity": ["case", ["==", ["within", "some-polygon"], true], 1,

["==", ["within", "some-polygon"], false], 0]`

CHANGELOG.md

asheemmamoowala · 2020-03-12T16:11:17Z

CHANGELOG.md

+* Clear source tiles when removing a layer ([#9305](https://github.com/mapbox/mapbox-gl-js/pull/9305))
+* Fix a bug where maps were not displaying inside elements with `dir=rtl`. ([#9332](https://github.com/mapbox/mapbox-gl-js/pull/9332))
+* Fix a rendering error for very old versions of Chrome (ca. 2016) where text would appear much bigger than intended ([#9349](https://github.com/mapbox/mapbox-gl-js/pull/9349))
+* Fix a bug where `icon-image` expression that evaluates to `''` produced a warning. ([#9380](https://github.com/mapbox/mapbox-gl-js/pull/9380))


Suggested change

* Fix a bug where `icon-image` expression that evaluates to `''` produced a warning. ([#9380](https://github.com/mapbox/mapbox-gl-js/pull/9380))

* Fix a bug where `icon-image` expression that evaluates to an empty string (`''`) produced a warning. ([#9380](https://github.com/mapbox/mapbox-gl-js/pull/9380))

asheemmamoowala · 2020-03-12T16:11:34Z

CHANGELOG.md

+* Fix a rendering error for very old versions of Chrome (ca. 2016) where text would appear much bigger than intended ([#9349](https://github.com/mapbox/mapbox-gl-js/pull/9349))
+* Fix a bug where `icon-image` expression that evaluates to `''` produced a warning. ([#9380](https://github.com/mapbox/mapbox-gl-js/pull/9380))
+* Prevent exception resulting from `line-dash-array` of empty length ([#9385](https://github.com/mapbox/mapbox-gl-js/pull/9385))
+* Improve scaling of patterns used in `line-pattern` on all device resolutions and pixel ratios ([#9266](https://github.com/mapbox/mapbox-gl-js/pull/9266))


Recommend moving this to the top section as well.

chloekraw

Looks great minus a few nits!

chloekraw · 2020-03-12T17:59:44Z

CHANGELOG.md

+
+### ✨ Features
+* Add `within` expression for testing whether an evaluated feature lies within a given GeoJSON object ([#9352](https://github.com/mapbox/mapbox-gl-js/pull/9352)). For example:<br>
+`"icon-opacity": ["case", ["==", ["within", "some-polygon"], true], 1,


the line break <br> breaks precedent from previous changelogs. It does seem to add clarity so I'm not necessarily against it, but I'm also not sure how I feel about it

chloekraw · 2020-03-12T18:00:42Z

CHANGELOG.md

+* Add `within` expression for testing whether an evaluated feature lies within a given GeoJSON object ([#9352](https://github.com/mapbox/mapbox-gl-js/pull/9352)). For example:<br>
+`"icon-opacity": ["case", ["==", ["within", "some-polygon"], true], 1,
+["==", ["within", "some-polygon"], false], 0]`
+* Map API functions such as `easeTo` and `flyTo` now support `padding: PaddingOptions` which lets developers shift the center of perspective for a map when building floating sidebars ([#8638](https://github.com/mapbox/mapbox-gl-js/pull/8638))


nit: which lets developers shift a map's center of perspective when building floating sidebars

chloekraw · 2020-03-12T18:01:09Z

CHANGELOG.md

+
+### 🍏 Improvements
+* Results from `queryRenderedFeatures` now have evaluated property values rather than raw expressions ([#9198](https://github.com/mapbox/mapbox-gl-js/pull/9198))
+* Improve scaling of patterns used in `line-pattern` on all device resolutions and pixel ratios. ([#9266](https://github.com/mapbox/mapbox-gl-js/pull/9266))


nit: remove period

chloekraw · 2020-03-12T18:02:30Z

CHANGELOG.md

+* Correctly adjust patterns added with `addImage(id, image, pixelRatio)` by the asset pixel ratio, not the device pixel ratio ([#9372](https://github.com/mapbox/mapbox-gl-js/pull/9372))
+* Allow needle argument to `in` expression to be false ([#9295](https://github.com/mapbox/mapbox-gl-js/pull/9295))
+* Fix exception thrown when trying to set `feature-state` for a layer that has been removed, fixes [#8634](https://github.com/mapbox/mapbox-gl-js/issues/8634) ([#9305](https://github.com/mapbox/mapbox-gl-js/pull/9305))
+* Fix a bug where maps were not displaying inside elements with `dir=rtl`. ([#9332](https://github.com/mapbox/mapbox-gl-js/pull/9332))


nit: remove period

addressed

v1.9.0-beta.1

ba35782

arindam1993 reviewed Mar 12, 2020

View reviewed changes

chloekraw reviewed Mar 12, 2020

View reviewed changes

Add -beta.1 to changelog versions for unit tests

d426389

karimnaaji suggested changes Mar 12, 2020

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

CHANGELOG.md Outdated Show resolved Hide resolved

CHANGELOG.md Outdated Show resolved Hide resolved

asheemmamoowala previously requested changes Mar 12, 2020

View reviewed changes

ryanhamley added 3 commits March 12, 2020 10:48

Update changelogs

fffb787

Add links in release description

3d341c0

Update 'features' header

b74f158

chloekraw approved these changes Mar 12, 2020

View reviewed changes

arindam1993 approved these changes Mar 12, 2020

View reviewed changes

karimnaaji approved these changes Mar 12, 2020

View reviewed changes

Update changelog

e33c24c

ryanhamley merged commit 68c6102 into release-caspian Mar 12, 2020

ryanhamley deleted the v1.9.0-beta.1 branch March 12, 2020 18:59

j8seangel pushed a commit to GlobalFishingWatch/mapbox-gl-js that referenced this pull request Dec 9, 2020

v1.9.0-beta.1 (mapbox#9417)

b74c8c8

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

v1.9.0-beta.1 #9417

v1.9.0-beta.1 #9417

ryanhamley commented Mar 12, 2020

arindam1993 Mar 12, 2020

arindam1993 Mar 12, 2020

arindam1993 Mar 12, 2020

arindam1993 Mar 12, 2020

arindam1993 Mar 12, 2020

chloekraw Mar 12, 2020

chloekraw Mar 12, 2020

chloekraw Mar 12, 2020

chloekraw Mar 12, 2020

chloekraw Mar 12, 2020

chloekraw Mar 12, 2020

chloekraw Mar 12, 2020

chloekraw Mar 12, 2020

chloekraw Mar 12, 2020

asheemmamoowala Mar 12, 2020

asheemmamoowala Mar 12, 2020

asheemmamoowala Mar 12, 2020

chloekraw left a comment

chloekraw Mar 12, 2020

chloekraw Mar 12, 2020

chloekraw Mar 12, 2020

chloekraw Mar 12, 2020

	* Clear source tiles when removing a layer ([#9305](https://github.com/mapbox/mapbox-gl-js/pull/9305))
	* Fix exception thrown when trying to set feature-state for a layer that has been removed, fixes [#8634](https://github.com/mapbox/mapbox-gl-js/issues/8634). ([#9305](https://github.com/mapbox/mapbox-gl-js/pull/9305))

	* Fix a bug where `icon-image` expression that evaluates to `''` produced a warning. ([#9380](https://github.com/mapbox/mapbox-gl-js/pull/9380))
	* Fix a bug where `icon-image` expression that evaluates to an empty string (`''`) produced a warning. ([#9380](https://github.com/mapbox/mapbox-gl-js/pull/9380))

v1.9.0-beta.1 #9417

v1.9.0-beta.1 #9417

Conversation

ryanhamley commented Mar 12, 2020

Launch Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chloekraw left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment