-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates Geocoding to match API #217
Conversation
@cammace, thanks for your PR! By analyzing the history of the files in this pull request, we identified @zugaldia, @ivovandongen and @sbma44 to be potential reviewers. |
This is a property and can be acquired by the user using |
Could I get someone on @mapbox/android for review :) |
* country codes, separated by commas. | ||
* @since 2.0.0 | ||
*/ | ||
public void setCountry(String country) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want to offer a varargs method here for convenience so that the comma separated format is abstracted:
public void setCountries(String... countries)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great point @ivovandongen, adding.
Thanks a ton for tackling this -- we're a bit thin on Android chops on the geocoding team.
|
@ivovandongen: I've added a countries option which takes in a String array, array was used here since it was already implemented that way in the @sbma44 Happy to help out on the geocoding Android side of things. For types, we allow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
We are missing a few options/parameters the geocoder gives you. This PR adds
limit
and exposescountry
in the auto complete widget. Still need to addlandmark
.cc: @zugaldia