Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cancel method to autocomplete widget #226

Merged
merged 2 commits into from
Dec 1, 2016
Merged

Conversation

cammace
Copy link

@cammace cammace commented Nov 30, 2016

Closes #206

cc: @ivovandongen for review

@mention-bot
Copy link

@cammace, thanks for your PR! By analyzing the history of the files in this pull request, we identified @zugaldia to be a potential reviewer.

@cammace cammace added this to the v2.0.0 milestone Nov 30, 2016
* @since 2.0.0
*/
public void cancelApiCall() {
if (call == null) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think we need to log this as it's not an uncommon occurrence. At most, log at debug I think.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed removing

@cammace cammace merged commit 668bf84 into master Dec 1, 2016
@cammace cammace deleted the cam-206-cancel branch December 1, 2016 15:25
@zugaldia zugaldia mentioned this pull request Feb 10, 2017
9 tasks
@zugaldia zugaldia mentioned this pull request Feb 22, 2017
9 tasks
@zugaldia zugaldia mentioned this pull request Mar 9, 2017
9 tasks
@zugaldia zugaldia mentioned this pull request Mar 17, 2017
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants