[android] - make changing base url a part of public API. #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tobrun, thanks for your PR! By analyzing the history of the files in this pull request, we identified @cammace, @ivovandongen and @zugaldia to be potential reviewers. |
cammace
reviewed
Dec 20, 2016
| * Get the base url of the API. | ||
| * | ||
| * @return the base url used as endpoint. | ||
| */ |
|
|
||
| public abstract MapboxBuilder setAccessToken(String accessToken); | ||
|
|
||
| public abstract String getAccessToken(); | ||
|
|
||
| /** | ||
| * Set the base url of the API. | ||
| */ |
| @@ -458,6 +442,11 @@ public MapboxDirections build() throws ServicesException { | |||
| return new MapboxDirections(this); | |||
| } | |||
|
|
|||
| @Override | |||
There was a problem hiding this comment.
No need to expose this in Directions v4, it has been deprecated.
| @@ -458,6 +444,11 @@ public Builder setClientAppName(String appName) { | |||
| return this; | |||
| } | |||
|
|
|||
| public Builder setBaseUrl(String baseUrl) { | |||
There was a problem hiding this comment.
Javadoc? Looks like we are also missing javadoc for the method above: setClientAppName
| @@ -277,6 +263,12 @@ public Builder setClientAppName(String appName) { | |||
| return this; | |||
| } | |||
|
|
|||
| @Override | |||
| @@ -448,6 +434,12 @@ public Builder setClientAppName(String appName) { | |||
| return this; | |||
| } | |||
|
|
|||
| @Override | |||
| @@ -318,6 +303,12 @@ public Builder setClientAppName(String appName) { | |||
| return this; | |||
| } | |||
|
|
|||
| @Override | |||
| @@ -375,6 +373,12 @@ public Builder setClientAppName(String appName) { | |||
| return this; | |||
| } | |||
|
|
|||
| @Override | |||
|
Also, build is failing since we are now using 5.0.0 snapshot correct? |
|
thanks for the review, the build is failing since 4.2.0 snapshot doesn't exist anymore -> that is why I created #247. IMO we should avoid using snapshots between projects except for doing some testing. |
tobrun
force-pushed
the
244-make-changing-base-url-public-api
branch
from
6e357ea to
b0432db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #244.