Batch geocoding support #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zugaldia, thanks for your PR! By analyzing the history of the files in this pull request, we identified @cammace, @ivovandongen and @tobrun to be potential reviewers. |
cammace
reviewed
Jan 10, 2017
| @@ -80,6 +82,10 @@ public GeocodingService getService() { | |||
| return call; | |||
| } | |||
|
|
|||
| if (builder.getQuery().contains(";")) { | |||
| throw new IllegalArgumentException("Use getBatchCall() for batch calls."); | |||
| * Used internally. | ||
| * | ||
| * @return batch call | ||
| * @since 1.0.0 |
| * | ||
| * @return The Geocoding v5 response | ||
| * @throws IOException Signals that an I/O exception of some sort has occurred. | ||
| * @since 1.0.0 |
| * @param bbox Optionally pass in a bounding box to limit results in. | ||
| * @param limit Optionally pass in a limit the amount of returning results. | ||
| * @return A retrofit Call object | ||
| * @since 1.0.0 |
| * Execute the batch call | ||
| * | ||
| * @param callback A Retrofit callback. | ||
| * @since 1.0.0 |
| @@ -129,6 +187,15 @@ public void cancelCall() { | |||
| } | |||
|
|
|||
| /** | |||
| * Cancel the batch call | |||
| * | |||
| * @since 1.0.0 | |||
| * clone the batch call | ||
| * | ||
| * @return cloned call | ||
| * @since 1.0.0 |
| import static org.junit.Assert.assertEquals; | ||
|
|
||
| /** | ||
| * Created by antonio on 1/10/17. |
|
@cammace Changes addressed, care to 👀 again? |
cammace
approved these changes
Jan 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add a new API specific for batch requests that can be used like:
Fixes #262.
Review: @cammace