Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added setters to location engine and javadoc #402

Merged
merged 3 commits into from
Mar 24, 2017
Merged

added setters to location engine and javadoc #402

merged 3 commits into from
Mar 24, 2017

Conversation

cammace
Copy link

@cammace cammace commented Mar 21, 2017

Closes #395

@cammace cammace self-assigned this Mar 21, 2017
@cammace cammace requested a review from zugaldia March 21, 2017 19:32
@mention-bot
Copy link

@cammace, thanks for your PR! By analyzing the history of the files in this pull request, we identified @zugaldia, @Guardiola31337 and @tobrun to be potential reviewers.

zugaldia
zugaldia requested changes Mar 24, 2017
View reviewed changes
...bandroid-services/src/main/java/com/mapbox/services/android/location/LostLocationEngine.java Outdated
.setInterval(1000)
.setFastestInterval(1000)
.setSmallestDisplacement(3.0f);
.setInterval(interval)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cammace I like where this is going, particularly the great javadoc added. I'd like to make this fields optional to set, like GMS does (example. How about we make them objects instead with a default value of null?

@cammace cammace merged commit 0e41ae9 into master Mar 24, 2017
@cammace cammace deleted the cam-395 branch March 24, 2017 17:19
@cammace cammace mentioned this pull request Mar 30, 2017
Closed
@cammace cammace mentioned this pull request Apr 15, 2017
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zugaldia zugaldia zugaldia approved these changes

Assignees

@cammace cammace

Labels
Feature Ready For Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cammace @mention-bot @zugaldia