Remove trailing zeros from coordinates #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zugaldia
requested changes
Mar 31, 2017
| @@ -27,24 +28,27 @@ | |||
| * @since 1.0.0 | |||
| */ | |||
| private Position(double longitude, double latitude, double altitude) { | |||
| // Used to remove any trailing zeros and prevent a coordinate being over 7 significant figures. | |||
| DecimalFormat decimalFormat = new DecimalFormat("0.######"); | |||
There was a problem hiding this comment.
Because this same logic is used in several place, how about exposing it as static utility method?
added 2 commits
April 4, 2017 16:55
zugaldia
requested changes
Apr 4, 2017
| @@ -47,4 +51,10 @@ public static String join(CharSequence delimiter, Object[] tokens) { | |||
| return sb.toString(); | |||
| } | |||
|
|
|||
| public static String formatCoordinate(double coordinate) { | |||
| // Used to remove any trailing zeros and prevent a coordinate being over 7 significant figures. | |||
There was a problem hiding this comment.
@cammace Let's make it a javadoc instead.
| public static String formatCoordinate(double coordinate) { | ||
| // Used to remove any trailing zeros and prevent a coordinate being over 7 significant figures. | ||
| DecimalFormat decimalFormat = new DecimalFormat("0.######", new DecimalFormatSymbols(Locale.US)); | ||
| return String.format(Locale.US, "%s", |
There was a problem hiding this comment.
@cammace We have a constant for the default locale already.
zugaldia
approved these changes
Apr 14, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #338