added convert distance method to TurfHelper #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zugaldia
requested changes
Jun 13, 2017
| if (factor == null) { | ||
| throw new TurfException("Invalid unit."); | ||
| } else if (!(distance >= 0)) { | ||
| throw new TurfException("distance must be a positive number"); |
There was a problem hiding this comment.
Please change the message to Distance must be a positive number. for consistency.
| Double factor = factors.get(originalUnit); | ||
| if (factor == null) { | ||
| throw new TurfException("Invalid unit."); | ||
| } else if (!(distance >= 0)) { |
There was a problem hiding this comment.
This case doesn't seem to be tested (negative distance), only invalid units are.
| thrown.expectMessage(startsWith("Invalid unit.")); | ||
| TurfHelpers.convertDistance(1, "foo"); | ||
| } | ||
|
|
zugaldia
approved these changes
Jun 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the convertDistance method https://github.com/Turfjs/turf/blob/master/packages/turf-helpers/index.js#L396. It also adds support for centimeters and feet.
cc: @zugaldia