Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flush Navigation Events Manually #601

Merged
merged 2 commits into from
Oct 13, 2017
Merged

Flush Navigation Events Manually #601

merged 2 commits into from
Oct 13, 2017

Conversation

electrostat
Copy link

@electrostat electrostat commented Oct 12, 2017 •
edited
Loading

Description

Change to public call to allow for events to be sent immediately.

@electrostat
Public flushEventsQueue
ae906cf 
- change flushEventsQueueImmediately to public, allowing nav to call it
@electrostat electrostat self-assigned this Oct 12, 2017
Guardiola31337
Guardiola31337 approved these changes Oct 13, 2017
View reviewed changes
Copy link
Contributor

@Guardiola31337 Guardiola31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@electrostat electrostat merged commit d3bb6dc into master Oct 13, 2017
@electrostat electrostat deleted the aa-public-flush-events branch October 13, 2017 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Guardiola31337 Guardiola31337 Guardiola31337 approved these changes

@zugaldia zugaldia Awaiting requested review from zugaldia

@cammace cammace Awaiting requested review from cammace

@danesfeder danesfeder Awaiting requested review from danesfeder

Assignees

@electrostat electrostat

Labels
Feature Ready For Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@electrostat @Guardiola31337