Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix attribution button color #252

Merged
merged 2 commits into from
Oct 3, 2023
Merged

Fix attribution button color #252

merged 2 commits into from
Oct 3, 2023

Conversation

evil159
Copy link
Contributor

@evil159 evil159 commented Oct 3, 2023

This PR fixes attribution button color not being applied on iOS. As well as, fixes the issue of attribution color not decoding correctly on Android.

yunikkk
yunikkk previously approved these changes Oct 3, 2023
View reviewed changes
@yunikkk
Copy link
Collaborator

yunikkk commented Oct 3, 2023

@evil159 could you reformat the project to fix the Android build? There is a make target for that, make format should do the job.

This one also fixes #134

@evil159 evil159 requested a review from yunikkk October 3, 2023 12:22
@evil159 evil159 enabled auto-merge October 3, 2023 12:29
@evil159 evil159 merged commit 9c19241 into main Oct 3, 2023
@evil159 evil159 deleted the rl/fix_attribution_button_color branch October 3, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunikkk yunikkk yunikkk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evil159 @yunikkk