Use "scanline" as the non-writable stream in test #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "list" stream is a Transform stream which is writable at least in current node versions.
tomhughes
force-pushed
the
invalid-writable
branch
from
72e5c73
to
357ae1b
Compare
|
Tests are failing on CI due to an unrelated issue. Diggin' |
|
I guess we should add node 6/7 to the CI checks as well? It was 6.9.2 where I was seeing this test fail... |
|
Oh that roundtrip size check often fails. I relax the tolerance on that when building for Fedora: http://pkgs.fedoraproject.org/cgit/rpms/nodejs-tilelive.git/tree/nodejs-tilelive-roundtrip.patch It tends to vary by platform exactly how much tolerance is needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "list" stream is a Transform stream which is writable at
least in current node versions.